Skip to content

Commit 434df7d

Browse files
committed
fixup! ENH/API: ExtensionArray.factorize
1 parent 31ed4c9 commit 434df7d

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

pandas/tests/extension/json/array.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ def factorize(self, na_sentinel=-1):
111111

112112
# fixup NA
113113
if self.isna().any():
114-
na_code = self.isna().argmax()
114+
na_code = labels[self.isna()][0]
115115

116116
labels[labels == na_code] = na_sentinel
117117
labels[labels > na_code] -= 1

pandas/tests/extension/json/test_json.py

+2-4
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,8 @@ class TestMissing(base.BaseMissingTests):
7575

7676

7777
class TestMethods(base.BaseMethodsTests):
78-
unhashable = pytest.mark.skip(reason="Unhashable")
79-
80-
@unhashable
81-
def test_factorize(self):
78+
@pytest.mark.skip(reason="Unhashable")
79+
def test_value_counts(self):
8280
pass
8381

8482

0 commit comments

Comments
 (0)