Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon elements that fall back to font have wrong size #6409

Closed
adidahiya opened this issue Sep 26, 2023 · 0 comments · Fixed by #6410
Closed

Icon elements that fall back to font have wrong size #6409

adidahiya opened this issue Sep 26, 2023 · 0 comments · Fixed by #6410
Assignees
@adidahiya
Labels
P2 Package: core Package: icons Type: bug

Comments

@adidahiya
Copy link
Contributor

Environment

  • Package version(s): core v5.3.2, icons v5.1.7
  • Operating System: macOS
  • Browser name and version: Chrome

Code Sandbox

N/A -- see current docs site

Steps to reproduce

  1. Render an <Icon size={IconSize.LARGE} />
  2. Prevent SVG icons from loading somehow (fail to include those separate webpack chunk files, block those resources on the asset server, etc.)

Actual behavior

Icons use font-size: inherit which results in a 14px icon even though the .bp5-icon-large class was applied.

image

Expected behavior

.bp5-icon-large class should make the icon element use font-size: 20px so that the fallback icon font is sized correctly

Possible solution

adjust core CSS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adidahiya adidahiya

Labels
P2 Package: core Package: icons Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[core] fix(Icon): use correct font-size for icon font fallback palantir/blueprint
1 participant
@adidahiya