Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 17 support #4391

Closed
karudo opened this issue Oct 28, 2020 · 3 comments · Fixed by #4403
Closed

React 17 support #4391

karudo opened this issue Oct 28, 2020 · 3 comments · Fixed by #4403
Assignees
Milestone

Comments

@karudo
Copy link

karudo commented Oct 28, 2020

React 17 released already, but peerDependencies contains "react": "^15.3.0 || 16", so there are npm warnings after React is updated

@adidahiya adidahiya added this to the 4.x milestone Oct 28, 2020
@adidahiya
Copy link
Contributor

It's on the 4.0 roadmap. We first need to drop support for 15.x, which is still used in some of our code bases. ETA is roughly EOY.

@adidahiya adidahiya self-assigned this Oct 28, 2020
@david-raine
Copy link

My project needs React 17 as it has multiple app root elements, so I updated ./node_modules/@blueprintjs/core.package.json directly with "react": "^15.3.0 || 16 || 17" and everything seems to be working well so far.

@dapetcu21
Copy link

dapetcu21 commented Nov 6, 2020

It doesn't need to wait for 4.0. React 17's only breaking change is the moving of event handlers from document root to React root element, which is unlikely to cause problems. It's a stepping stone release for future compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants