Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Callout with icon does not provide left padding as shown on example page #2388

Closed
will-stone opened this issue Apr 13, 2018 · 4 comments

Comments

@will-stone
Copy link
Contributor

Bug report

  • Package version(s): 2.1.1
  • Browser and OS versions: Chrome/Firefox, MacOS 10.12

Steps to reproduce

  1. Create a Callout with intent, e.g.
<Callout intent="success" title="test">Testing testing testing</Callout>

Actual behavior

image

Expected behavior

image

@giladgray
Copy link
Contributor

@will-stone this does not repro on the docs site which suggests that your app styling is interfering. the .pt-callout-icon should have float: left; height: 100%; so it occupies the entire left side.

@will-stone
Copy link
Contributor Author

@giladgray How have you got it working?

I've created a CodeSandbox that demonstrates the issue I'm having: https://codesandbox.io/s/qklq5q0j09 is there something I'm doing incorrectly?

@llorca
Copy link
Contributor

llorca commented Apr 14, 2018

I looked at it, it's pretty weird. In the code sandbox, the height: 100% and float: left are indeed present, but they no effect, and there doesn't seem to be any conflicting styles 🤔

@giladgray
Copy link
Contributor

yuck. so throwing display: flex on the parent of .pt-callout fixes the icon layout. not sure how that works, as the icon is one level deeper. seems these styles never worked properly outside the docs environment 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants