Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[InputGroup] Add default paddingRight to input without rightElement #1861

Closed
alxmiron opened this issue Dec 4, 2017 · 4 comments · Fixed by #2386
Closed

[InputGroup] Add default paddingRight to input without rightElement #1861

alxmiron opened this issue Dec 4, 2017 · 4 comments · Fixed by #2386

Comments

@alxmiron
Copy link
Contributor

alxmiron commented Dec 4, 2017

Hello team!
Just noticed a small issue with text input groups. As I understand, CSS component TextInput should display same as default InputGroup JS component.
However, TextInput has padding-right: 12px, but InputGroup (withou rightElement) has padding-right: 0 (inline style rule).

CSS:
screenshot at dec 04 17-48-07

JS:
screenshot at dec 04 17-49-03

I guess InputGroup also should have padding-right.
The problem reason is here

@alxmiron alxmiron changed the title [InputGroup] Add default paddingRight for input without rightElement [InputGroup] Add default paddingRight to input without rightElement Dec 4, 2017
@cmslewis
Copy link
Contributor

cmslewis commented Dec 4, 2017

The InputGroup isn't actually a 1:1 mapping to .pt-input, but we do have an issue open to make that a thing for 2.0, at least as far as naming goes. This is a good thing to track together with that. 👍

@llorca
Copy link
Contributor

llorca commented Dec 4, 2017

yup, also this issue may help with styling inconsistencies #1425

@nickensoul
Copy link

nickensoul commented Sep 4, 2019

@cmslewis @llorca can you approve this changes has been delivered into release?
Looks like on the 3rd version there is no change about paddings and still adds inline padding.
It's just a bad way to stylish via inline styles, maybe add className tot the input that reflects right icon existence?

@adidahiya
Copy link
Contributor

@nickensoul this is an old issue, please open a new one if you wish to file a bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants