Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Scrollable overlays breaks canOutsideClickClose with hasBackdrop false #1188

Closed
ghost opened this issue Jun 4, 2017 · 0 comments · Fixed by #2399
Closed

Adding Scrollable overlays breaks canOutsideClickClose with hasBackdrop false #1188

ghost opened this issue Jun 4, 2017 · 0 comments · Fixed by #2399
Assignees
Milestone

Comments

@ghost
Copy link

ghost commented Jun 4, 2017

Bug report

  • Package version(s): Chrome
  • Browser and OS versions: OSX

Steps to reproduce

Code from the github overlay docs:

<Overlay className="pt-overlay-scroll-container" isOpen={this.state.isOpen}  hasBackdrop={false} onClose={this.handleClose}>
...
</Overlay
..... 
handleClose = () => this.setState({ isOpen: false });

Actual behavior

  • canOutsideClickClose no longer closes the overlay.

Expected behavior

  • canOutsideClickClose closing the overlay.

Workaround

Use backdropClassName to set background:transparent.

Thank you :)

@ghost ghost changed the title Adding Scrollable overlays breaks canOutsideClickClose with hasBackdrop false Adding Scrollable overlays breaks canOutsideClickClose with hasBackdrop false, breaks stackable overlays Jun 4, 2017
@ghost ghost changed the title Adding Scrollable overlays breaks canOutsideClickClose with hasBackdrop false, breaks stackable overlays Adding Scrollable overlays breaks canOutsideClickClose with hasBackdrop false Jun 4, 2017
@ghost ghost closed this as completed Jun 5, 2017
@ghost ghost reopened this Jun 8, 2017
@giladgray giladgray added this to the 3.0.0 milestone Apr 17, 2018
@giladgray giladgray self-assigned this Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants