Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch vulnerability from dependency requirejs #429

Closed
pcorpet opened this issue Jul 11, 2024 · 3 comments
Closed

Patch vulnerability from dependency requirejs #429

pcorpet opened this issue Jul 11, 2024 · 3 comments

Comments

@pcorpet
Copy link

pcorpet commented Jul 11, 2024

See vulnerability here GHSA-x3m3-4wpv-5vgc

The requirement comes from a transitive dependency inside dependency-tree. A fix could be to ask them to fix or use another library.

@gestj
Copy link

gestj commented Jul 11, 2024

requirejs/requirejs#1854

No plans to address that report, this project is not under active development.

:(

Only current workaround is downgrading to madge 0.6.0 🤯

requirejs  *
Severity: high
jrburke requirejs vulnerable to prototype pollution - https://github.com/advisories/GHSA-x3m3-4wpv-5vgc
fix available via `npm audit fix --force`
Will install [email protected], which is a breaking change
node_modules/requirejs
  module-lookup-amd  >=4.0.0
  Depends on vulnerable versions of requirejs
  node_modules/module-lookup-amd
    filing-cabinet  >=1.2.2
    Depends on vulnerable versions of module-lookup-amd
    node_modules/filing-cabinet
      dependency-tree  >=5.2.0
      Depends on vulnerable versions of filing-cabinet
      node_modules/dependency-tree
        madge  >=1.0.0
        Depends on vulnerable versions of dependency-tree
        node_modules/madge

@callumacrae
Copy link

callumacrae commented Jul 25, 2024

requirejs/requirejs#1854

No plans to address that report, this project is not under active development.

was fixed in 2.3.7!

i'm using yarn resolutions to work around. in package.json:

  "resolutions": {
    "madge/**/requirejs": "^2.3.7"
  },

@pcorpet
Copy link
Author

pcorpet commented Aug 22, 2024

Indeed, this is solved for me as well, even without the extra resolutions.

@pcorpet pcorpet closed this as completed Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants