From d8075a9f0a95de05656cb70b8e03a9fc9c93f56a Mon Sep 17 00:00:00 2001 From: Stan Girard Date: Mon, 6 Feb 2023 19:32:33 +0100 Subject: [PATCH] fix(s3): fixed issue with access policy --- aws/s3/getter.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/aws/s3/getter.go b/aws/s3/getter.go index 13cd0c2..63aa3c8 100644 --- a/aws/s3/getter.go +++ b/aws/s3/getter.go @@ -58,8 +58,12 @@ func GetS3ToPublicBlockAccess(s aws.Config, b []types.Bucket) []S3toPublicBlockA Bucket: aws.String(*bucket.Name), } resp, err := svc.GetPublicAccessBlock(context.TODO(), params) - if err != nil || (resp.PublicAccessBlockConfiguration != nil && resp.PublicAccessBlockConfiguration.BlockPublicAcls) { - s3toPublicBlockAccess = append(s3toPublicBlockAccess, S3toPublicBlockAccess{*bucket.Name, true}) + if err != nil { + if resp.PublicAccessBlockConfiguration != nil && resp.PublicAccessBlockConfiguration.BlockPublicAcls { + s3toPublicBlockAccess = append(s3toPublicBlockAccess, S3toPublicBlockAccess{*bucket.Name, true}) + } else { + s3toPublicBlockAccess = append(s3toPublicBlockAccess, S3toPublicBlockAccess{*bucket.Name, false}) + } } else { s3toPublicBlockAccess = append(s3toPublicBlockAccess, S3toPublicBlockAccess{*bucket.Name, false}) }