-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hb-service support for FreeBSD #1349
Conversation
Merging into freebsd branch |
Using
Done
Removed it, we don't need to offer this function. It's no longer enabled for new debian-based linux installs.
Maybe we should remove the option for now then. I install avahi and dbus, I can see they are running, but Homebridge still won't use it with the
This is the correct behaviour, I adjusted the rc file to restart Homebridge automatically after it dies. The
That's fine, I don't see official binaries for FreeBSD anyway. |
See changes in https://github.com/oznu/homebridge-config-ui-x/tree/freebsd Available for testing in @test https://github.com/oznu/homebridge-config-ui-x/wiki/How-To-Test-Upcoming-Changes |
Using the version currently in
That seems to get everything working as expected. |
Indeed, a fresh install this way does. Something must be different about how I was doing dev. Only nit that sticks out now is that the system-info-widget shows the OS as unknown. |
IP address info is missing |
Fixed that, for some reason that I am sure will come back to bite me, I had an exception to not load this on FreeBSD, it seems to work fine now though. |
Tested again in a TrueNAS Jail (FreeBSD 13.1) - seems to work as expected. |
systeminformation figures out the platform here. Unfortunately, my install is aarch64 (arm64) and it seems that machdep.bootmethod is only registered on i386/amd64 variants. Reported upstream here. |
So my stance on FreeBSD support. While I'm happy to have this included, I won't be promoting its use as an officially supported platform. This is mainly because I can't automatically test it using GitHub actions (and I don't want to use the VM inside an action method). It will stay in the "Other Platforms" section of the Homebridge wiki. |
There are a couple of work-in-progress approaches for adding FreeBSD support to GitHub actions (not using the VM route) so hopefully this will be possible in the future. |
Following up to the offer in issue 784, this patch is the start of FreeBSD support for hb-service.
There's a lot of features in here to get working and a few aren't complete, but now seemed like a good starting point for discussion and feedback and work can continue in this PR.
The rc service script is based on work by Stefan Bethke, who responded that the blog post from which it came is CC0.