Added a Network widget

[seidnerj]

It displays sent & received megabytes per second as well as a graph of the overall throughput per second.

[seidnerj]

I fixed the linting warnings, can try to re-run now.

[seidnerj]

Hmmm, fetching the network stats fails on Windows due to a timeout for some reason, can't figure out why - any help would be appreciated.

[seidnerj]

I tried replicating the issue that shows up in the windows tests using a Windows 11 VM but could not replicate it. Could someone help?

[seidnerj]

Okay, fixed. All tests have passed, see here: https://github.com/seidnerj/homebridge-config-ui-x/actions/runs/1855056483

[seidnerj]

Sorry for the all the mess, next time I'm going to work off of a feature branch and only merge to the fork's master when done.

At any rate, what exists right now in the fork's master branch works and passes all the tests.

Would appreciate merging this pull request.

Thanks!

[seidnerj]

@oznu, can you please check this?

Thanks in advance

[oznu]

I'll review this soon. Quite busy with life at the moment sorry.

[seidnerj]

No worries. Thx.

…

On Mon, 21 Feb 2022 at 23:59 oznu ***@***.***> wrote: I'll review this soon. Quite busy with life at the moment sorry. — Reply to this email directly, view it on GitHub <#1292 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA7URNKTQM6O5YPVAVWWKDLU4KYVFANCNFSM5OHJEJAQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[seidnerj]

Is there any way I can help getting this merged? Thanks.

[oznu]

Thanks for this, looks good, however a few things:

1. I think this should be an optional widget, the default layout should remain unchanged
2. the network utilisation tracking should not occur server side if the widget is not enabled - I can see certain low powered devices not liking the additional calls to check network activity every few seconds. Maybe only start the interval to check network activity when requested for the first time?

[seidnerj]

I've removed the network widget from the default layout. Regarding your second point, am happy to do that but I'm not sure how - could you please point me to a similar behavior in the existing code or provide some other guidance? Thanks in advance

[oznu]

@seidnerj if you don't mind rebasing to the current master to resolve the merge conflict, I'll merge this in and fix up that part before doing a release.

If that works for you?

[seidnerj]

Sure, much appreciated. I will do that and update the thread. Thanks a lot!

…

On Thu, 7 Apr 2022 at 12:11 oznu ***@***.***> wrote: @seidnerj <https://github.com/seidnerj> if you don't mind rebasing to the current master to resolve the merge conflict, I'll merge this in and fix up that part before doing a release. If that works for you? — Reply to this email directly, view it on GitHub <#1292 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA7URNLBRRLYTUSTLTELF73VD2RFBANCNFSM5OHJEJAQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[seidnerj]

Done. Thanks!

[seidnerj]

Strange issue with the tests. I've run the e2e tests locally and it finished successfully. I also launched and used the server successfully. Any idea what's the issue?

[oznu]

Made a few changes if you would like to take a look 😄

4.43.0-test.7
https://github.com/oznu/homebridge-config-ui-x/wiki/How-To-Test-Upcoming-Changes
https://github.com/oznu/homebridge-config-ui-x/tree/network-widget

1. Increased default width of the widget.
2. Changed default position in mobile layout.
3. Changed units from MB/s to Mb/s - most users i think still measure their internet speed in Mb/s.
4. Polling will only start the first time the get network info method is called.

[seidnerj]

Looks great! Thanks a lot!

[oznu]

On second thoughts, maybe we should only poll for network activity when the client needs it. There is little point having 10 seconds worth of history before the page loads.

That will mean we aren't burning CPU cycles every second only to have the data discarded in 10 seconds.

[seidnerj]

Agreed. I guess this can be said about other stats as well.