Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error messages on empty input and various crashes #104

Open
oyvindln opened this issue Aug 24, 2023 · 0 comments
Open

Better error messages on empty input and various crashes #104

oyvindln opened this issue Aug 24, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@oyvindln
Copy link
Owner

If you input an empty file you get a unhelpful message like

Traceback (most recent call last):
  File "/home/usrname/vhs-decode/vhsdecode/process.py", line 212, in build_json
    black = jout["videoParameters"]["black16bIre"]
TypeError: 'NoneType' object is not subscriptable
Cannot build json: 'NoneType' object is not subscriptable
saving JSON and exiting
Traceback (most recent call last):
  File "/home/usrname/vhs-decode/vhsdecode/process.py", line 212, in build_json
    black = jout["videoParameters"]["black16bIre"]
TypeError: 'NoneType' object is not subscriptable
Cannot build json: 'NoneType' object is not subscriptable

The same message is often output for other erros with or without other messages which can be confusing, need to add in something a bit more explanatory here.

@oyvindln oyvindln added the bug Something isn't working label Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant