Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new link checker - lychee #2672

Closed
DariuszPorowski opened this issue May 20, 2023 · 3 comments · Fixed by #2673
Closed

feat: new link checker - lychee #2672

DariuszPorowski opened this issue May 20, 2023 · 3 comments · Fixed by #2673
Labels
enhancement New feature or request

Comments

@DariuszPorowski
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I'm always frustrated with markdown-link-check. lychee is an alternative that works IMHO!

Describe the solution you'd like

lychee part of megalinter

Describe alternatives you've considered

N/A

Additional context

N/A

@Kurt-von-Laven
Copy link
Collaborator

Looks like it can be installed via cargo, and I agree that our community has faced a number of difficulties regarding markdown-link-check, such as security incidents that are fixed a bit slowly and performance issues. The project is currently on life support. My experience has been that the lack of retry logic leads to many more false positives than all other linters combined. We obviously still value having a link checker and were never tempted to disable it, so I don't mean to bash a useful tool. I raise these issues since we are doing a major release, so it would be a good time to take markdown-link-check out if lychee is added within the next week or two. Please let me know if anyone feels that we should keep markdown-link-check in v7.

@DariuszPorowski
Copy link
Contributor Author

@Kurt-von-Laven tried cargo, but it requires to setup deps firs: https://github.com/lycheeverse/lychee#build-dependencies and do not feel it the right approach for megaliter.

@Kurt-von-Laven
Copy link
Collaborator

Ah, sorry. That makes sense. Whatever is easiest is probably best.

@DariuszPorowski DariuszPorowski changed the title new link checker: lychee feat: new link checker - lychee Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants