From 94bd2d87f451aae89034a532b723008744e1cd4b Mon Sep 17 00:00:00 2001 From: Boshen <1430279+Boshen@users.noreply.github.com> Date: Wed, 19 Feb 2025 15:31:15 +0000 Subject: [PATCH] fix(language_server): fix `clippy::significant_drop_in_scrutinee` warning (#9234) --- Cargo.toml | 1 + crates/oxc_language_server/src/main.rs | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/Cargo.toml b/Cargo.toml index e006c725fe0a1..d51528cddcbcb 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -71,6 +71,7 @@ doc_markdown = "allow" # `const` functions do not make sense for our project because this is not a `const` library. # This rule also confuses newcomers and forces them to add `const` blindlessly without any reason. missing_const_for_fn = "allow" +significant_drop_in_scrutinee = "warn" # cargo cargo = { level = "warn", priority = -1 } multiple_crate_versions = "allow" diff --git a/crates/oxc_language_server/src/main.rs b/crates/oxc_language_server/src/main.rs index c6be04da2f81d..db87670c3d9e2 100644 --- a/crates/oxc_language_server/src/main.rs +++ b/crates/oxc_language_server/src/main.rs @@ -514,7 +514,8 @@ impl Backend { async fn handle_file_update(&self, uri: Url, content: Option, version: Option) { if let Some(Some(_root_uri)) = self.root_uri.get() { - if let Some(diagnostics) = self.server_linter.read().await.run_single(&uri, content) { + let diagnostics = self.server_linter.read().await.run_single(&uri, content); + if let Some(diagnostics) = diagnostics { self.client .publish_diagnostics( uri.clone(),