Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(linter): false positive in consistent-function-scoping in AssignmentExpressions #5159

Closed
DonIsaac opened this issue Aug 24, 2024 · 3 comments · Fixed by #5312
Closed

bug(linter): false positive in consistent-function-scoping in AssignmentExpressions #5159

DonIsaac opened this issue Aug 24, 2024 · 3 comments · Fixed by #5312
Assignees
@Arian94
Labels
A-linter Area - Linter C-bug Category - Bug good first issue Experience Level - Good for newcomers

Comments

@DonIsaac
Copy link
Contributor

This snippet should not violate unicorn/consistent-function-scoping, but it currently does:

module.exports = function foo() {}
@DonIsaac DonIsaac added C-bug Category - Bug A-linter Area - Linter labels Aug 24, 2024
@DonIsaac DonIsaac added the good first issue Experience Level - Good for newcomers label Aug 24, 2024
@Arian94
Copy link
Contributor

Arian94 commented Aug 28, 2024

@camc314 you working on this?

@camc314
Copy link
Contributor

camc314 commented Aug 28, 2024

@camc314 you working on this?

not currently. feel free to do it

@camc314 camc314 assigned Arian94 and unassigned camc314 Aug 28, 2024
@Arian94
Copy link
Contributor

Arian94 commented Aug 28, 2024

@camc314 alright. tnx.

@Arian94 Arian94 mentioned this issue Aug 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arian94 Arian94

Labels
A-linter Area - Linter C-bug Category - Bug good first issue Experience Level - Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(linter/unicorn): consistent-function-scoping false positive on assignment expression Arian94/oxc
3 participants
@camc314 @DonIsaac @Arian94