From 6fc40f030e171203e9260feba1840b3f8d614dce Mon Sep 17 00:00:00 2001
From: overlookmotel <557937+overlookmotel@users.noreply.github.com>
Date: Tue, 17 Dec 2024 16:34:09 +0000
Subject: [PATCH] refactor(transformer/class-properties): pass
 `BoundIdentifier`s by reference (#7968)

Don't pass by value when passing by reference is sufficient.
---
 .../src/es2022/class_properties/private_field.rs   | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/crates/oxc_transformer/src/es2022/class_properties/private_field.rs b/crates/oxc_transformer/src/es2022/class_properties/private_field.rs
index 94be2fd6de0f8..1b576b4d5b205 100644
--- a/crates/oxc_transformer/src/es2022/class_properties/private_field.rs
+++ b/crates/oxc_transformer/src/es2022/class_properties/private_field.rs
@@ -389,14 +389,14 @@ impl<'a, 'ctx> ClassProperties<'a, 'ctx> {
 
             self.transform_static_assignment_expression(
                 expr,
-                prop_binding,
-                class_binding,
+                &prop_binding,
+                &class_binding,
                 class_symbol_id,
                 is_declaration,
                 ctx,
             );
         } else {
-            self.transform_instance_assignment_expression(expr, prop_binding, ctx);
+            self.transform_instance_assignment_expression(expr, &prop_binding, ctx);
         }
     }
 
@@ -416,12 +416,11 @@ impl<'a, 'ctx> ClassProperties<'a, 'ctx> {
     // `AssignmentTarget::PrivateFieldExpression` on left, and that clones in
     // `transform_assignment_expression` can be elided.
     #[inline]
-    #[expect(clippy::needless_pass_by_value)]
     fn transform_static_assignment_expression(
         &self,
         expr: &mut Expression<'a>,
-        prop_binding: BoundIdentifier<'a>,
-        class_binding: BoundIdentifier<'a>,
+        prop_binding: &BoundIdentifier<'a>,
+        class_binding: &BoundIdentifier<'a>,
         class_symbol_id: Option<SymbolId>,
         is_declaration: bool,
         ctx: &mut TraverseCtx<'a>,
@@ -575,11 +574,10 @@ impl<'a, 'ctx> ClassProperties<'a, 'ctx> {
     // `AssignmentTarget::PrivateFieldExpression` on left, and that clones in
     // `transform_assignment_expression` can be elided.
     #[inline]
-    #[expect(clippy::needless_pass_by_value)]
     fn transform_instance_assignment_expression(
         &self,
         expr: &mut Expression<'a>,
-        prop_binding: BoundIdentifier<'a>,
+        prop_binding: &BoundIdentifier<'a>,
         ctx: &mut TraverseCtx<'a>,
     ) {
         let assign_expr = match ctx.ast.move_expression(expr) {