diff --git a/changelog/unreleased/enhancement-feedback-link b/changelog/unreleased/enhancement-feedback-link new file mode 100644 index 00000000000..abbc9a30b22 --- /dev/null +++ b/changelog/unreleased/enhancement-feedback-link @@ -0,0 +1,5 @@ +Enhancement: Feedback link + +We've added a feedback link in the topbar which opens a survey in a new tab. The intention is to gather feedback from users. There is a config option to disable the link (see docs "getting started"). + +https://github.com/owncloud/web/pull/5468 diff --git a/docs/getting-started.md b/docs/getting-started.md index ab54865001f..e55900f0f10 100644 --- a/docs/getting-started.md +++ b/docs/getting-started.md @@ -33,6 +33,8 @@ substring of a value of the authenticated user. Examples are `/Shares`, `/{{.Id} - `options.disablePreviews` Set this option to `true` to disable previews in all the different file listing views. The only list view that is not affected by this is the trash bin, as that doesn't allow showing previews at all. - `options.previewFileExtensions` Specifies which filetypes will be previewed in the ui. For example to only preview jpg and txt files set this option to `["jpg", "txt"]`. +- `options.disableFeedbackLink` Set this option to `true` to disable the feedback link in the topbar. Keeping it enabled (value `false` or absence of the option) + allows ownCloud to get feedback from your user base through a dedicated survey website. ## Setting up backend and running diff --git a/packages/web-runtime/package.json b/packages/web-runtime/package.json index ab4bcd12ef8..5ee653f8a22 100644 --- a/packages/web-runtime/package.json +++ b/packages/web-runtime/package.json @@ -12,7 +12,7 @@ "lodash-es": "^4.17.21", "luxon": "^1.27.0", "oidc-client": "1.10.1", - "owncloud-design-system": "^8.0.0-rc2", + "owncloud-design-system": "^8.0.0-rc3", "owncloud-sdk": "1.0.0-2296", "p-queue": "^6.1.1", "tippy.js": "^6.3.1", diff --git a/packages/web-runtime/src/components/FeedbackLink.vue b/packages/web-runtime/src/components/FeedbackLink.vue new file mode 100644 index 00000000000..4d387ef3cd6 --- /dev/null +++ b/packages/web-runtime/src/components/FeedbackLink.vue @@ -0,0 +1,35 @@ + + + diff --git a/packages/web-runtime/src/components/TopBar.vue b/packages/web-runtime/src/components/TopBar.vue index 5469f49d873..97c6d5a70d2 100644 --- a/packages/web-runtime/src/components/TopBar.vue +++ b/packages/web-runtime/src/components/TopBar.vue @@ -17,6 +17,7 @@ + { + it('has no accessibility violations', async () => { + const wrapper = mount(FeedbackLink, { + localVue, + directives: { + OcTooltip + } + }) + + expect( + await axe(wrapper.html(), { + rules: { + region: { enabled: false } + } + }) + ).toHaveNoViolations() + expect(wrapper).toMatchSnapshot() + }) +}) diff --git a/packages/web-runtime/tests/unit/components/__snapshots__/FeedbackLink.spec.js.snap b/packages/web-runtime/tests/unit/components/__snapshots__/FeedbackLink.spec.js.snap new file mode 100644 index 00000000000..a5f4d4f3712 --- /dev/null +++ b/packages/web-runtime/tests/unit/components/__snapshots__/FeedbackLink.spec.js.snap @@ -0,0 +1,7 @@ +// Jest Snapshot v1, https://goo.gl/fbAQLP + +exports[`FeedbackLink component has no accessibility violations 1`] = ` +
+ +
+`; diff --git a/packages/web-runtime/tests/unit/components/__snapshots__/TopBar.spec.js.snap b/packages/web-runtime/tests/unit/components/__snapshots__/TopBar.spec.js.snap index 0da0363c1a7..13d200e5ee8 100644 --- a/packages/web-runtime/tests/unit/components/__snapshots__/TopBar.spec.js.snap +++ b/packages/web-runtime/tests/unit/components/__snapshots__/TopBar.spec.js.snap @@ -11,6 +11,7 @@ exports[`Top Bar component Displays applications menu 1`] = ` + @@ -29,6 +30,7 @@ exports[`Top Bar component when search bar hidden globally Hides search bar even + @@ -47,6 +49,7 @@ exports[`Top Bar component when search bar hidden globally Hides the search bar + @@ -65,6 +68,7 @@ exports[`Top Bar component when search bar visible globally Displays search bar + @@ -83,6 +87,7 @@ exports[`Top Bar component when search bar visible globally Hides the search bar + diff --git a/tests/vrt/baseline/oc10/topBar.png b/tests/vrt/baseline/oc10/topBar.png index fe8b3abd0d4..e0255374909 100644 Binary files a/tests/vrt/baseline/oc10/topBar.png and b/tests/vrt/baseline/oc10/topBar.png differ diff --git a/tests/vrt/baseline/ocis/topBar.png b/tests/vrt/baseline/ocis/topBar.png index 66680b2310a..f89ff8e632a 100644 Binary files a/tests/vrt/baseline/ocis/topBar.png and b/tests/vrt/baseline/ocis/topBar.png differ diff --git a/yarn.lock b/yarn.lock index f9a8ec055fd..fd8b88abac6 100644 --- a/yarn.lock +++ b/yarn.lock @@ -8150,10 +8150,10 @@ ospec@3.1.0: dependencies: glob "^7.1.3" -owncloud-design-system@^8.0.0-rc2: - version "8.0.0-rc2" - resolved "https://registry.yarnpkg.com/owncloud-design-system/-/owncloud-design-system-8.0.0-rc2.tgz#e82f948ead4f9f6258cb6bf49556da4a2aa6503b" - integrity sha512-HJlI+UMN/F5cqU2KKeh0RqiLj6RLwB41xoTERUzet7hT48tDRRwBDsdXhjx4p1uqyasm2Gq1Kwqg/xe+rdJ+hg== +owncloud-design-system@^8.0.0-rc3: + version "8.0.0-rc3" + resolved "https://registry.yarnpkg.com/owncloud-design-system/-/owncloud-design-system-8.0.0-rc3.tgz#3c471411e8b96a335f75707a6b4bf904b270015c" + integrity sha512-cWUNiL0fFbusxmbP24RN9MAri8Zcx4Hc/BQP3ZDaZ3dc482Qvmde22M7cqyD63s1uV7sLdaad8MAu0FZAXVdqQ== owncloud-sdk@1.0.0-2296: version "1.0.0-2296"