Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix max quota validation #8536

Closed
4 tasks done
kulmann opened this issue Mar 3, 2023 · 2 comments · Fixed by #8571
Closed
4 tasks done

Fix max quota validation #8536

kulmann opened this issue Mar 3, 2023 · 2 comments · Fixed by #8571
Assignees
@AlexAndBear
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working

Comments

@kulmann
Copy link
Contributor

kulmann commented Mar 3, 2023 •
edited
Loading

Followup for #8490

There are some issues with max quota validation in the admin-settings app:

  • the Edit panel in the right sidebar of the Users view doesn't use the max quota capability. There is no validation before sending the request. The quota modal does this validation before sending the request and shows an error message in red.
  • The Edit quota batch action and context menu action do have the validation, but the max quota is not formatted properly. Should use our formatFileSize helper for a nice, standardized and localized filesize formatting.
  • equal to or less than, the to is missing after equal

Additional issue:

  • It is still possible to choose unlimited

Screenshot 2023-03-03 at 15 55 58
@kulmann kulmann added Type:Bug Something isn't working Priority:p2-high Escalation, on top of current planning, release blocker labels Mar 3, 2023
@AlexAndBear AlexAndBear self-assigned this Mar 8, 2023
@AlexAndBear AlexAndBear mentioned this issue Mar 8, 2023
Merged
10 tasks
@AlexAndBear
Copy link
Contributor

@kulmann
Fix landed in #8571

Could you please move The Edit quota batch action seems to have a copy&paste text issue to another issue, this has nothing to do with the quota validation in general 🥇

@kulmann
Copy link
Contributor Author

kulmann commented Mar 8, 2023

@kulmann Fix landed in #8571

Could you please move The Edit quota batch action seems to have a copy&paste text issue to another issue, this has nothing to do with the quota validation in general 🥇

done 👍 thank you!

@micbar micbar mentioned this issue Mar 9, 2023
Closed
4 tasks
@kulmann kulmann moved this to Done in Web Support Board Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexAndBear AlexAndBear

Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working
Projects
No open projects
Web Support Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Max quota follow up owncloud/web
2 participants
@kulmann @AlexAndBear