Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve business logic leaks ofweb-app-external #10256

Closed
Tracked by #7930
kulmann opened this issue Jan 3, 2024 · 0 comments · Fixed by #10346
Closed
Tracked by #7930

Resolve business logic leaks ofweb-app-external #10256

kulmann opened this issue Jan 3, 2024 · 0 comments · Fixed by #10346

Comments

@kulmann
Copy link
Contributor

kulmann commented Jan 3, 2024

Describe the technical debt

Looking at the CreateAndUpload.vue component in web-app-files and the useFilesActions.ts composable in web-pkg we have some business logic of web-app-external which leaked to the outside of the app.

Expected behavior

ownCloud Web offers the possibility for web-app-external to register create file and open file actions as an extension. The files app and the useFileActions composable should then utilize those in a generic way instead of referencing e.g. the vuex store of the external app (grep for External/mimeTypes).

Actual behavior

Files app and useFileActions composable depend on the external app.

@kulmann kulmann moved this from Qualification to Refactor / Technical Debt in Infinite Scale Team Board Jan 3, 2024
@kulmann kulmann mentioned this issue Jan 3, 2024
30 tasks
@github-project-automation github-project-automation bot moved this from Refactor / Technical Debt to Done in Infinite Scale Team Board Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant