reenable shipped apps is not working

[DeepDiver1975]

• the array $this->disabledApps is never set
• even if - how is the state preserved between two invocations of the upgrade application?

[VicDeo]

the array $this->disabledApps is never set

true

even if - how is the state preserved between two invocations of the upgrade application?

it is serialized into the session:
https://github.com/owncloud/updater/blob/master/src/Command/DisableNotShippedAppsCommand.php#L42

[DeepDiver1975]

it is serialized into the session:

using the session in a cli command?

[DeepDiver1975]

reoping until open question is answered

[Croydon]

Please fix this. It is really annoying to enable apps after every single update.

[Croydon]

Discussion: owncloud/core#18312

[VicDeo]

@DeepDiver1975 yes, for CLI too

[DeepDiver1975]

This was not a serious question. Using sessions in cli mode is non sense

[VicDeo]

@DeepDiver1975 ok, then it uses Registry singleton in the scope of upgrade:start command to obtain persistence in CLI mode https://github.com/owncloud/updater/blob/master/src/Command/StartCommand.php

[VicDeo]

@DeepDiver1975 tested migration stable9->master with
#307
#346
#347
applied

all apps (shipped/not shipped) are being reenabled correctly