Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot download files in ownCloud Web #5985

Closed
wkloucek opened this issue Mar 31, 2023 · 0 comments · Fixed by #6022
Closed

Cannot download files in ownCloud Web #5985

wkloucek opened this issue Mar 31, 2023 · 0 comments · Fixed by #6022
Assignees
@kobergj
Labels
Priority:p1-urgent Consider a hotfix release with only that fix Type:Bug Type:Regression

Comments

@wkloucek
Copy link
Contributor

Describe the bug

When installing oCIS 3.0.0-alpha.1 with the oCIS Helmchart 0.2.0, I cannot download files from oC Web.

Steps to reproduce

Steps to reproduce the behavior:

  1. Deploy oCIS with Helm Chart
  2. Upload a file via Web
  3. Download file via Web

Expected behavior

File will be downloaded

Actual behavior

File download fails

Additional context

The signing-key cannot be downloaded by Web because the ocs services panics:

kubectl logs -f -n ocis service/ocs
2023/03/31 14:26:30 http: panic serving 172.17.0.1:1193: runtime error: invalid memory address or nil pointer dereference
goroutine 45 [running]:
net/http.(*conn).serve.func1()
	net/http/server.go:1850 +0xbf
panic({0x38cab20, 0x528f320})
	runtime/panic.go:890 +0x262
github.com/owncloud/ocis/v2/protogen/gen/ocis/services/store/v0.(*storeService).Read(0xc001732ab8, {0x3d366e0, 0xc000beaae0}, 0x0?, {0x0, 0x0, 0x0})
	github.com/owncloud/ocis/v2/protogen/gen/ocis/services/store/v0/store.pb.micro.go:62 +0x54
github.com/owncloud/ocis/v2/services/ocs/pkg/service/v0.Ocs.GetSigningKey({0xc000a96ea0, {{{0x3d2a360, 0xc001630500}, 0x1, {0x0, 0x0}, {0xc000b26800, 0x10, 0x1f4}, {0xc00162cc60, ...}, ...}}, ...}, ...)
	github.com/owncloud/ocis/v2/services/ocs/pkg/service/v0/users.go:33 +0x205
net/http.HandlerFunc.ServeHTTP(0x38a13c0?, {0x7fc4b984bd98?, 0xc00055cfc0?}, 0xc0004c2690?)
	net/http/server.go:2109 +0x2f
github.com/go-chi/chi/v5.(*Mux).routeHTTP(0xc000913da0, {0x7fc4b984bd98, 0xc00055cfc0}, 0xc00170a700)
	github.com/go-chi/chi/[email protected]/mux.go:442 +0x216
net/http.HandlerFunc.ServeHTTP(0x3d366e0?, {0x7fc4b984bd98?, 0xc00055cfc0?}, 0x35992b0?)
	net/http/server.go:2109 +0x2f
github.com/owncloud/ocis/v2/services/ocs/pkg/service/v0/response.VersionCtx.func1({0x7fc4b984bd98, 0xc00055cfc0}, 0xc00170a600)
	github.com/owncloud/ocis/v2/services/ocs/pkg/service/v0/response/version.go:90 +0x353
net/http.HandlerFunc.ServeHTTP(0xc001732d80?, {0x7fc4b984bd98?, 0xc00055cfc0?}, 0xc001732d60?)
	net/http/server.go:2109 +0x2f
github.com/go-chi/chi/v5.(*Mux).ServeHTTP(0xc000913da0, {0x7fc4b984bd98, 0xc00055cfc0}, 0xc00170a600)
	github.com/go-chi/chi/[email protected]/mux.go:71 +0x355
github.com/go-chi/chi/v5.(*Mux).Mount.func1({0x7fc4b984bd98, 0xc00055cfc0}, 0xc00170a600)
	github.com/go-chi/chi/[email protected]/mux.go:314 +0x19c
net/http.HandlerFunc.ServeHTTP(0x38a13c0?, {0x7fc4b984bd98?, 0xc00055cfc0?}, 0xc000bee100?)
	net/http/server.go:2109 +0x2f
github.com/go-chi/chi/v5.(*Mux).routeHTTP(0xc000913d40, {0x7fc4b984bd98, 0xc00055cfc0}, 0xc00170a600)
	github.com/go-chi/chi/[email protected]/mux.go:442 +0x216
net/http.HandlerFunc.ServeHTTP(0x3d366e0?, {0x7fc4b984bd98?, 0xc00055cfc0?}, 0x528dc80?)
	net/http/server.go:2109 +0x2f
github.com/owncloud/ocis/v2/services/ocs/pkg/middleware.OCSFormatCtx.func1({0x7fc4b984bd98, 0xc00055cfc0}, 0xc00170a500)
	github.com/owncloud/ocis/v2/services/ocs/pkg/middleware/format.go:22 +0x477
net/http.HandlerFunc.ServeHTTP(0x3d366e0?, {0x7fc4b984bd98?, 0xc00055cfc0?}, 0xa?)
	net/http/server.go:2109 +0x2f
github.com/owncloud/ocis/v2/ocis-pkg/middleware.ExtractAccountUUID.func1.1({0x7fc4b984bd98, 0xc00055cfc0}, 0xc00170a400)
	github.com/owncloud/ocis/v2/ocis-pkg/middleware/account.go:75 +0x322
net/http.HandlerFunc.ServeHTTP(0x7fc4e0f9ba68?, {0x7fc4b984bd98?, 0xc00055cfc0?}, 0x38617e0?)
	net/http/server.go:2109 +0x2f
github.com/go-chi/chi/v5/middleware.StripSlashes.func1({0x7fc4b984bd98, 0xc00055cfc0}, 0xc00170a400)
	github.com/go-chi/chi/[email protected]/middleware/strip.go:30 +0x139
net/http.HandlerFunc.ServeHTTP(0xc00171f140?, {0x7fc4b984bd98?, 0xc00055cfc0?}, 0xc00171f120?)
	net/http/server.go:2109 +0x2f
github.com/go-chi/chi/v5.(*Mux).ServeHTTP(0xc000913d40, {0x7fc4b984bd98, 0xc00055cfc0}, 0xc00170a400)
	github.com/go-chi/chi/[email protected]/mux.go:71 +0x355
github.com/go-chi/chi/v5.(*Mux).Mount.func1({0x7fc4b984bd98, 0xc00055cfc0}, 0xc00170a400)
	github.com/go-chi/chi/[email protected]/mux.go:314 +0x19c
net/http.HandlerFunc.ServeHTTP(0x38a13c0?, {0x7fc4b984bd98?, 0xc00055cfc0?}, 0xc000bec124?)
	net/http/server.go:2109 +0x2f
github.com/go-chi/chi/v5.(*Mux).routeHTTP(0xc000913ce0, {0x7fc4b984bd98, 0xc00055cfc0}, 0xc00170a400)
	github.com/go-chi/chi/[email protected]/mux.go:442 +0x216
net/http.HandlerFunc.ServeHTTP(0x40c0f5?, {0x7fc4b984bd98?, 0xc00055cfc0?}, 0x3d35850?)
	net/http/server.go:2109 +0x2f
github.com/owncloud/ocis/v2/services/ocs/pkg/middleware.LogTrace.func1({0x7fc4b984bd98, 0xc00055cfc0}, 0xc00170a300)
	github.com/owncloud/ocis/v2/services/ocs/pkg/middleware/logtrace.go:22 +0x22d
net/http.HandlerFunc.ServeHTTP(0x3d34260?, {0x7fc4b984bd98?, 0xc00055cfc0?}, 0x38a4660?)
	net/http/server.go:2109 +0x2f
github.com/owncloud/ocis/v2/ocis-pkg/middleware.Logger.func1.1({0x3d34260, 0xc001718000}, 0xc00170a300)
	github.com/owncloud/ocis/v2/ocis-pkg/middleware/logger.go:17 +0xc8
net/http.HandlerFunc.ServeHTTP(0x3abd860?, {0x3d34260?, 0xc001718000?}, 0xd?)
	net/http/server.go:2109 +0x2f
github.com/owncloud/ocis/v2/ocis-pkg/middleware.Version.func1.1({0x3d34260, 0xc001718000}, 0xc001716160?)
	github.com/owncloud/ocis/v2/ocis-pkg/middleware/version.go:18 +0x18f
net/http.HandlerFunc.ServeHTTP(0x3abd860?, {0x3d34260?, 0xc001718000?}, 0x16?)
	net/http/server.go:2109 +0x2f
github.com/owncloud/ocis/v2/ocis-pkg/middleware.Secure.func1({0x3d34260, 0xc001718000}, 0xc00170a300)
	github.com/owncloud/ocis/v2/ocis-pkg/middleware/header.go:57 +0x31d
net/http.HandlerFunc.ServeHTTP(0xc000a49220?, {0x3d34260?, 0xc001718000?}, 0xc00170a300?)
	net/http/server.go:2109 +0x2f
github.com/go-chi/cors.(*Cors).Handler.func1({0x3d34260, 0xc001718000}, 0xc00170a300)
	github.com/go-chi/[email protected]/cors.go:228 +0x1bd
net/http.HandlerFunc.ServeHTTP(0x3abd860?, {0x3d34260?, 0xc001718000?}, 0xd?)
	net/http/server.go:2109 +0x2f
github.com/owncloud/ocis/v2/ocis-pkg/middleware.NoCache.func1({0x3d34260, 0xc001718000}, 0x3599201?)
	github.com/owncloud/ocis/v2/ocis-pkg/middleware/header.go:20 +0x313
net/http.HandlerFunc.ServeHTTP(0x3d366e0?, {0x3d34260?, 0xc001718000?}, 0x35992b0?)
	net/http/server.go:2109 +0x2f
github.com/go-chi/chi/v5/middleware.RequestID.func1({0x3d34260, 0xc001718000}, 0xc00170a200)
	github.com/go-chi/chi/[email protected]/middleware/request_id.go:76 +0x22d
net/http.HandlerFunc.ServeHTTP(0xc00170a200?, {0x3d34260?, 0xc001718000?}, 0xc00170a200?)
	net/http/server.go:2109 +0x2f
github.com/go-chi/chi/v5/middleware.RealIP.func1({0x3d34260, 0xc001718000}, 0xc00170a200)
	github.com/go-chi/chi/[email protected]/middleware/realip.go:35 +0x9e
net/http.HandlerFunc.ServeHTTP(0x3d36638?, {0x3d34260?, 0xc001718000?}, 0x528dc40?)
	net/http/server.go:2109 +0x2f
github.com/go-chi/chi/v5.(*Mux).ServeHTTP(0xc000913ce0, {0x3d34260, 0xc001718000}, 0xc00170a100)
	github.com/go-chi/chi/[email protected]/mux.go:88 +0x310
github.com/owncloud/ocis/v2/services/ocs/pkg/service/v0.Ocs.ServeHTTP(...)
	github.com/owncloud/ocis/v2/services/ocs/pkg/service/v0/service.go:68
github.com/owncloud/ocis/v2/services/ocs/pkg/service/v0.instrument.ServeHTTP(...)
	github.com/owncloud/ocis/v2/services/ocs/pkg/service/v0/instrument.go:24
github.com/owncloud/ocis/v2/services/ocs/pkg/service/v0.logging.ServeHTTP(...)
	github.com/owncloud/ocis/v2/services/ocs/pkg/service/v0/logging.go:24
github.com/owncloud/ocis/v2/ocis-pkg/middleware.TraceContext.func1({0x3d34260, 0xc001718000}, 0xc00170a000)
	github.com/owncloud/ocis/v2/ocis-pkg/middleware/tracing.go:19 +0x184
net/http.HandlerFunc.ServeHTTP(0x7fc4b984bd18?, {0x3d34260?, 0xc001718000?}, 0x7fc4b990a4f8?)
	net/http/server.go:2109 +0x2f
github.com/owncloud/ocis/v2/services/ocs/pkg/service/v0.tracing.ServeHTTP({{0x3d20fa0?, 0xc000578770?}}, {0x3d34260, 0xc001718000}, 0x7fc4b9928948?)
	github.com/owncloud/ocis/v2/services/ocs/pkg/service/v0/tracing.go:22 +0x6a
net/http.serverHandler.ServeHTTP({0xc000bea210?}, {0x3d34260, 0xc001718000}, 0xc00170a000)
	net/http/server.go:2947 +0x30c
net/http.(*conn).serve(0xc0004bc000, {0x3d366e0, 0xc001634cc0})
	net/http/server.go:1991 +0x607
created by net/http.(*Server).Serve
	net/http/server.go:3102 +0x4db

If the store and ocs service use the owncloud/ocis:2.0.0 image, downloads work
There have been introduced some changes between 2.0.0 and 3.0.0-alpha.1, that may or may not be related:
see git diff v2.0.0...v3.0.0-alpha.1 services/ocs/
@wkloucek wkloucek mentioned this issue Mar 31, 2023
Closed
@micbar micbar added the Priority:p1-urgent Consider a hotfix release with only that fix label Apr 3, 2023
@micbar micbar moved this from Qualification to Prio 1 in Infinite Scale Team Board Apr 5, 2023
@kobergj kobergj self-assigned this Apr 5, 2023
@kobergj kobergj mentioned this issue Apr 6, 2023
Merged
@github-project-automation github-project-automation bot moved this from Prio 1 to Done in Infinite Scale Team Board Apr 6, 2023
@ScharfViktor ScharfViktor mentioned this issue May 17, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kobergj kobergj

Labels
Priority:p1-urgent Consider a hotfix release with only that fix Type:Bug Type:Regression
Projects
Infinite Scale Team Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Panic in OCS service kobergj/ocis
3 participants
@micbar @kobergj @wkloucek