Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] Sort out test-acceptance-core-api in cs3org/reva #5450

Closed
phil-davis opened this issue Jan 24, 2023 · 3 comments · Fixed by cs3org/reva#3627
Closed

[QA] Sort out test-acceptance-core-api in cs3org/reva #5450

phil-davis opened this issue Jan 24, 2023 · 3 comments · Fixed by cs3org/reva#3627
Assignees
Labels

Comments

@phil-davis
Copy link
Contributor

PR #5430 changed the "make" target test-acceptance-core-api to test-acceptance-from-core-api in ocis.

cs3org/reva edge and master branches also have test-acceptance-core-api in their Makefile but it does not seem to be used by the drone CI of cs3org/reva - the drone CI fetches all the test code from the ocis repo, and uses the ocis Makefile for running the tests.

  1. see if there is anything else that uses the test-acceptance-* Makefile targets in cs3org/reva (maybe they are useful for developers who want to run tests, or?)

  2. if they are not used, then remove them from Makefile to avoid future confusion.
    if they are used, then get the names consistent with what is used in ocis.

@grgprarup grgprarup self-assigned this Jan 24, 2023
@grgprarup
Copy link
Contributor

grgprarup commented Jan 25, 2023

Currently, there are two make targets in reva edge branch Makefile, test-acceptance-api and test-acceptance-core-api the latter one was added in PR cs3org/reva#3591, but the CI in Reva use make targets from ocis and make targets of reva itself have not used in CI.
But in reva master branch this PR https://github.com/cs3org/reva/pull/3592/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52 will add those make targets.

IMO those make targets test-acceptance-api and test-acceptance-core-api in the cs3org/reva Makefile can be removed. @phil-davis what do you say?
I think, refactoring of README.md in cs3org/reva, where core is cloned to run the acceptance test is needed.

@phil-davis
Copy link
Contributor Author

what do you say?

yes, remove both Makefile targets, and refactor the README instructions. Do that in a PR to reva edge.

Then I will make the same changes to cs3org/reva#3592 (reva master) and that will be merged "some day".

@phil-davis
Copy link
Contributor Author

phil-davis commented Jan 26, 2023

@grgprarup please also make a PR to reva master to remove this stuff. (similar to cs3org/reva#3622 )

Then I can review it and get it merged.

My waiting PR to master got merged last night, so the test code in reva master is now running the API tests from owncloud/ocis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants