-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QA] Sort out test-acceptance-core-api in cs3org/reva #5450
Comments
Currently, there are two make targets in IMO those make targets |
yes, remove both Makefile targets, and refactor the README instructions. Do that in a PR to reva edge. Then I will make the same changes to cs3org/reva#3592 (reva master) and that will be merged "some day". |
@grgprarup please also make a PR to reva master to remove this stuff. (similar to cs3org/reva#3622 ) Then I can review it and get it merged. My waiting PR to master got merged last night, so the test code in reva master is now running the API tests from |
PR #5430 changed the "make" target
test-acceptance-core-api
totest-acceptance-from-core-api
in ocis.cs3org/reva
edge and master branches also havetest-acceptance-core-api
in theirMakefile
but it does not seem to be used by the drone CI ofcs3org/reva
- the drone CI fetches all the test code from the ocis repo, and uses the ocisMakefile
for running the tests.see if there is anything else that uses the
test-acceptance-*
Makefile
targets in cs3org/reva (maybe they are useful for developers who want to run tests, or?)if they are not used, then remove them from
Makefile
to avoid future confusion.if they are used, then get the names consistent with what is used in ocis.
The text was updated successfully, but these errors were encountered: