OCS error response code for Update/Delete shares have changed

[saw-jan]

Describe the bug

The error ocs codes for update and delete shares have changed from 998 to 996 and from 400 to 996 respectively. These changes have caused the test's failure (#3996)

The change seems to appear from commit 09b89f7

But the new changes look GOOD. So, I think the tests should be refactored to the new changes.

Steps to reproduce

1. As admin, share a folder with user1 with permissions 31
2. As user1, share a folder with user2 with permissions 31
3. As user2, share a folder with user3 with permissions 17
4. As user1, try to update/delete the last share (step 3)

Expected behavior (Previously)

Try to edit share

have 998 ocs error response code

curl -uuser1:1234 -XPUT "https://localhost:9200/ocs/v1.php/apps/files_sharing/api/v1/shares/22c7271a-7bec-4883-a6d3-f7fa9ff965b5" \
-d"permissions=31" -k

<ocs>
  <meta>
    <status>error</status>
    <statuscode>998</statuscode>
    <message>cant find requested share</message>
  </meta>
</ocs>

Try to delete share

have 400 ocs error response code

curl -uuser1:1234 -XDELETE "https://localhost:9200/ocs/v1.php/apps/files_sharing/api/v1/shares/22c7271a-7bec-4883-a6d3-f7fa9ff965b5" -vk

<?xml version="1.0" encoding="UTF-8"?>
<ocs>
  <meta>
    <status>error</status>
    <statuscode>400</statuscode>
    <message>missing shareWith</message>
  </meta>
</ocs>

Actual behavior

Try to edit share

The ocs error response code is 996

curl -uuser1:1234 -XPUT "https://localhost:9200/ocs/v1.php/apps/files_sharing/api/v1/shares/6b2481a7-0e20-45eb-9808-0209629f1f5d" \
-d"permissions=31" -k

<?xml version="1.0" encoding="UTF-8"?>
<ocs>
  <meta>
    <status>error</status>
    <statuscode>996</statuscode>
    <message>grpc update share request failed</message>
  </meta>
</ocs>

Try to delete share

The ocs error response code is 996

curl -uuser1:1234 -XDELETE "https://localhost:9200/ocs/v1.php/apps/files_sharing/api/v1/shares/6b2481a7-0e20-45eb-9808-0209629f1f5d" -k

<?xml version="1.0" encoding="UTF-8"?>
<ocs>
  <meta>
    <status>error</status>
    <statuscode>996</statuscode>
    <message>grpc delete share request failed</message>
  </meta>
</ocs>

[saw-jan]

IMO, the new changes look OK.
CC @individual-it @phil-davis

[butonic]

hm, no, it seems we broke something:

• 996 is a generic internal server error, whereas
• 998 is a not found error and
• 400 is the OCS version of an HTTP Bad Request status.

so the 996 hides the actual error

[butonic]

since this is resharing related, maybe @kobergj already has a hunch

[kobergj]

@butonic I can explain the first error code change. The PUT request returns 996 now because GetShare returns NotFound when using the json share manager but BadRequest when going through cs3 share manager. So we can teach ocs service to understand the BadRequest or adjust the error code in cs3 manager.

I don't understand the DELETE error. missing shareWith is only thrown when the shareWith is missing. It doesn't event talk to the share manager in that case.
@saw-jan Are we sure the error message in the DELETE case is the correct one?

[saw-jan]

I don't understand the DELETE error. missing shareWith is only thrown when the shareWith is missing. It doesn't event talk to the share manager in that case.

@kobergj Yeah, the error message for DELETE is missing shareWith but that's with older commit id (commit just before 09b89f7).
With current latest oCIS, the DELETE has grpc delete share request failed message

[saw-jan]

hm, no, it seems we broke something:

• 996 is a generic internal server error, whereas
• 998 is a not found error and
• 400 is the OCS version of an HTTP Bad Request status.

so the 996 hides the actual error

The error messages look related to the request so I thought that was a correct response, my bad!.

[kobergj]

@saw-jan Thanks! We found the issue and are working on a fix currently 👍