File in collabora opens in read-only mode for the owner

[ScharfViktor]

Test with wopi:

• start docker-compose up -d https://github.com/owncloud/ocis/blob/master/deployments/examples/ocis_wopi/docker-compose.yml
• admin creates file odt (file should be opened in collabora)
• add content and save.
• close file and open again

Actual result: file opens in read-only permissions mode

ocis_wopi_collabora log

wsd-00008-00404 2022-06-08 16:05:47.519043 [ docbroker_017 ] WRN  Un-successful WOPI::Lock with status 409, failure reason: "The file is locked by Collabora" and response: {"message": "The file is locked by Collabora"}| wsd/Storage.cpp:977

wsd-00008-00404 2022-06-08 16:05:47.519195 [ docbroker_017 ] ERR  Failed to lock!| wsd/DocumentBroker.cpp:882

[wkloucek]

Looks like a locking race condition. The first Collabora session holds the lock and did not yet release it because it didn't yet save the file. Then the second Collabora session already tries to open the still locked file and fails.

We should at least investigate in how we can improve this.

[micbar]

Needs investigation. The unlock should happen.

[wkloucek]

Needs investigation. The unlock should happen.

The unlock happens. But not as fast as the user opens again that file. And since the session is currently closing, you can't just resume the edit.

[C0rby]

I can't reproduce this with the current master.
When I try to close and open the file quickly then collabora show "cleaning up last session" before opening the file as usual.

[ScharfViktor]

Couldn't reproduce it. no log in collabora