Fix the permissions of the contactsmanager

[LEDfan]

AFAIK the permissions are wrong, and the delete or createOrUpdate methods would never been called.

CC @DeepDiver1975

[scrutinizer-notifier]

The inspection completed: No new issues

[ghost]

🚀 Test PASSed. 🚀
Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/3091/
🚀 Test PASSed. 🚀

[DeepDiver1975]

no - the old implementation is correct - only if the permissions returned by the address book contain the necessary permission the action is executed.

[LEDfan]

Mm okay.
If the getPermissions() function returns 32 (\OCP\PERMISSION_ALL), and you need PERMISSION_CREATE (4), then the method should be called right?

I have made a test: http://3v4l.org/B8HqW .

[DeepDiver1975]

Bloody php ....

31 & 4 = 4

// but
PERMISSION_ALL & PERMISSION_CREATE = 0

[DeepDiver1975]

@bantu

[bantu]

@DeepDiver1975 Looking.

[bantu]

@DeepDiver1975 Conceptionally, this patch looks correct.

$bitfield & $bitmask will answer whether the bit represented by $bitmask is set in $bitfield. The result is an integer, either 0 for no or $bitmask for yes. This can be implicitly cast to boolean via use in an if statement.

I have the feeling you're just seeing #6101 in action here.

[DeepDiver1975]

@LEDfan sorry for the confusion - I mixed up the diff - yes your patch looks valid

Can I ask you to add a unit test? We don't want to run into this again - THX

[DeepDiver1975]

@bantu thanks for having a look - regarding #6101 - a PR would be great 😉

[nickvergessen]

PR has been merged: #12421 @LEDfan can you rebase this on master?

[LEDfan]

@nickvergessen I'll rebase. @DeepDiver1975 I'm going to write the unit tests :)