Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky acceptance tests because suite expects an ordered list of shares #40093

Closed
aduffeck opened this issue May 23, 2022 · 5 comments
Closed
Assignees
Labels

Comments

@aduffeck
Copy link
Contributor

The acceptance test suite expects the list of shares returned by the ocs API to be ordered, which is currently not guaranteed (see https://github.com/owncloud/core/blob/master/tests/acceptance/features/bootstrap/Sharing.php#L2037).

The cs3 share manager for examples uses uuids as share ids and sorts the returned list by those (I believe) which causes flaky tests as seen in https://drone.owncloud.com/owncloud/ocis/12005.

@phil-davis phil-davis self-assigned this May 23, 2022
@aduffeck
Copy link
Contributor Author

Note: The list of received shares is also not guaranteed to be sorted by creation date, just like the list of owned shares. I'm not sure if that needs to be adjusted in the test suite as well.

@phil-davis
Copy link
Contributor

Thinking... - might need to refactor a bit to remember "the last share" at an earlier point in the test code.

@phil-davis
Copy link
Contributor

Example PR with this problem: owncloud/ocis#3697

@phil-davis
Copy link
Contributor

This should be improved (or fixed) by #40114

The refactored API test code is running in:
oCIS owncloud/ocis#3908
reva edge cs3org/reva#2915
reva master cs3org/reva#2914

I will deal with the 2 new test fails in reva (issue cs3org/reva#2916 ) separately. I don't think that they impact the test code in any significant way.

Please ping me if any problems are found, and close when you think this is working well.

@phil-davis
Copy link
Contributor

I added some comments to issue cs3org/reva#2916

The test code changes seem to be fine. I will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants