-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flaky acceptance tests because suite expects an ordered list of shares #40093
Comments
Note: The list of received shares is also not guaranteed to be sorted by creation date, just like the list of owned shares. I'm not sure if that needs to be adjusted in the test suite as well. |
Thinking... - might need to refactor a bit to remember "the last share" at an earlier point in the test code. |
Example PR with this problem: owncloud/ocis#3697 |
This should be improved (or fixed) by #40114 The refactored API test code is running in: I will deal with the 2 new test fails in reva (issue cs3org/reva#2916 ) separately. I don't think that they impact the test code in any significant way. Please ping me if any problems are found, and close when you think this is working well. |
I added some comments to issue cs3org/reva#2916 The test code changes seem to be fine. I will close this issue. |
The acceptance test suite expects the list of shares returned by the ocs API to be ordered, which is currently not guaranteed (see https://github.com/owncloud/core/blob/master/tests/acceptance/features/bootstrap/Sharing.php#L2037).
The cs3 share manager for examples uses uuids as share ids and sorts the returned list by those (I believe) which causes flaky tests as seen in https://drone.owncloud.com/owncloud/ocis/12005.
The text was updated successfully, but these errors were encountered: