Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version suffix support in core #33315

Closed
7 tasks
PVince81 opened this issue Oct 26, 2018 · 8 comments
Closed
7 tasks

Add version suffix support in core #33315

PVince81 opened this issue Oct 26, 2018 · 8 comments

Comments

@PVince81
Copy link
Contributor

PVince81 commented Oct 26, 2018

Required for Semver.

We need the ability to add a parseable string "dev1", "beta1", etc.

We currently have $Version (array) and $VersionString (string) in version.php. I think we should consolidate these into an actual version string and not an array.

Then in the version parsing code we extract it as array and cache it. (there was a cache somewhere).

  • core version
    • consolidate version string in version.php
    • adjust release scripts
    • communicate this change, I'm pretty sure there are many scripts out there relying on this
    • need backport to stable10 and be careful that all works fine on upgrade
  • app manager
    • make sure app manager properly parses and understands app versions, min-version, max-version containing suffixes

@DeepDiver1975 @VicDeo @phil-davis

@PVince81 PVince81 added this to the backlog milestone Oct 26, 2018
@PVince81 PVince81 self-assigned this Oct 26, 2018
@DeepDiver1975
Copy link
Member

We currently have $Version (array) and $VersionString (string) in version.php. I think we should consolidate these into an actual version string and not an array.

👍

@ownclouders
Copy link
Contributor

GitMate.io thinks the contributor most likely able to help you is @phil-davis.

Possibly related issues are #79 (Add SVG support ), #25373 (Add search support on the REPORT method), #16309 (Add native support for One time password [OTP]), #30093 (Add support heic), and #31622 (Add keeweb support).

@PVince81
Copy link
Contributor Author

PVince81 commented Nov 5, 2018

First attempt by @DeepDiver1975 in #33361 shows that it would require many API changes as clients are requesting the ownCloud version and receive an array.

This means we can't backport suffix support to OC 10 as it would break APIs.

We need to evaluate whether we can still provide API additions and keep backward compatible in OC 10 without breaking the semantics. Not sure if possible as if the version is 10.2.3beta and the suffix is ignored by clients it would be evaluated as 10.2.3 stable.

@phil-davis
Copy link
Contributor

I think we are stuck with a 4 part numeric for v10 like 10.0.10.4 10.1.0.5 etc. We can continue putting alpha beta rc in version string to indicate the release status, and that is no officially parsed anywhere for the purpose of triggering db migrations or app compatibility etc.

@PVince81 PVince81 removed their assignment Nov 7, 2018
@PVince81 PVince81 added the v11 label Nov 27, 2018
@PVince81
Copy link
Contributor Author

let's do the suffix thing only for OC 11.

OC 10 will be Semver-ish with at least the minor/patch component differentiation without breaking APIs.

@PVince81
Copy link
Contributor Author

  • also add git-sha field ? (for app dailies)

@micbar micbar removed the v11 label Jan 18, 2021
@stale
Copy link

stale bot commented Sep 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status/STALE label Sep 19, 2021
@stale
Copy link

stale bot commented Sep 20, 2021

This issue has been automatically closed.

@stale stale bot closed this as completed Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants