-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version suffix support in core #33315
Comments
👍 |
GitMate.io thinks the contributor most likely able to help you is @phil-davis. Possibly related issues are #79 (Add SVG support ), #25373 (Add search support on the REPORT method), #16309 (Add native support for One time password [OTP]), #30093 (Add support heic), and #31622 (Add keeweb support). |
First attempt by @DeepDiver1975 in #33361 shows that it would require many API changes as clients are requesting the ownCloud version and receive an array. This means we can't backport suffix support to OC 10 as it would break APIs. We need to evaluate whether we can still provide API additions and keep backward compatible in OC 10 without breaking the semantics. Not sure if possible as if the version is 10.2.3beta and the suffix is ignored by clients it would be evaluated as 10.2.3 stable. |
I think we are stuck with a 4 part numeric for v10 like 10.0.10.4 10.1.0.5 etc. We can continue putting alpha beta rc in version string to indicate the release status, and that is no officially parsed anywhere for the purpose of triggering db migrations or app compatibility etc. |
let's do the suffix thing only for OC 11. OC 10 will be Semver-ish with at least the minor/patch component differentiation without breaking APIs. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed. |
Required for Semver.
We need the ability to add a parseable string "dev1", "beta1", etc.
We currently have
$Version
(array) and$VersionString
(string) in version.php. I think we should consolidate these into an actual version string and not an array.Then in the version parsing code we extract it as array and cache it. (there was a cache somewhere).
@DeepDiver1975 @VicDeo @phil-davis
The text was updated successfully, but these errors were encountered: