Fix import error #495
Merged
Fix import error #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DeepDiver1975, thanks for your PR! By analyzing the annotation information on this pull request, we identified @jancborchardt, @Henni and @skjnldsv to be potential reviewers |
Current coverage is 12.24% (diff: 0.00%)@@ master #495 diff @@
==========================================
Files 47 47
Lines 831 825 -6
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 101 101
+ Misses 730 724 -6
Partials 0 0
|
|
Nice! 👍 |
|
If #480 gets merged, the changes to the *.css may not be needed anymore. 👎 |
|
Nice catch! Well, merge this one, then override with your pr? |
…dback on import of an invalid vcard
DeepDiver1975
force-pushed
the
fix-import-error
branch
from
4dfe407 to
983defb
Compare
|
rebased |
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
once owncloud/core#25905 is merged import of an invalid vcard as described in #488 is not possible.
A temporary notification is show to the user.
In addition this pr fixes import of the same file multiple times - fixes #391
And also cleans up with the styling