This repository has been archived by the owner on Dec 23, 2019. It is now read-only.
fix(pack): remove unnecessary toast error message of pack informations #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeremyDec
requested review from
antleblanc,
AxelPeter,
cbourgois,
euhmeuh,
FredericEspiau,
frenautvh,
ganeshkumar1989,
Jisay,
jleveugle,
marie-j,
radireddy and
varun257
as code owners
antleblanc
previously approved these changes
Feb 1, 2019
| @@ -121,7 +121,6 @@ angular.module('managerApp').controller('PackCtrl', class PackCtrl { | |||
| }) | |||
| .catch((err) => { | |||
| this.inError = true; | |||
| this.TucToast.error(this.$translate.instant('pack_xdsl_oops_an_error_is_occured')); | |||
| return this.$q.reject(err); | |||
There was a problem hiding this comment.
Is the reject still relevant?
There was a problem hiding this comment.
Hmm good point, it is no more relevant
JeremyDec
force-pushed
the
fix/pack-wrong-display-error
branch
from
394ba04 to
365a928
Compare
antleblanc
approved these changes
Feb 1, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MBP-271