Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.7 #11

Closed
xqt opened this issue Dec 13, 2023 · 3 comments
Closed

Add support for Python 3.7 #11

xqt opened this issue Dec 13, 2023 · 3 comments

Comments

@xqt
Copy link
Contributor

xqt commented Dec 13, 2023

Pywikibot framework uses sseclient which is not maintained any longer for 3 years. Therefore I would like to change the SSE client moving from sseclient to request-sse. Unfortunately requests-sse does not support Python 3.7; would you support it for Pywikibot framework?

See also: https://phabricator.wikimedia.org/T309380

@overcat
Copy link
Owner

overcat commented Dec 13, 2023

In version 0.3.1, I added support for 3.7. However, the lifecycle of 3.7 has already ended (see https://endoflife.date/python), and in future versions, I may have to drop the support.

@xqt
Copy link
Contributor Author

xqt commented Dec 14, 2023

In version 0.3.1, I added support for 3.7.

Great, thanks a lot

However, the lifecycle of 3.7 has already ended (see https://endoflife.date/python), and in future versions, I may have to drop the support.

I know that but most Pywikibot users (26 %) are having Python 3.7 possibly due to toolforge support. I guess Pywikibot does not drop Python 3.7 support before 2025. Anyway if you drop that support we would still have support for it with older releases of requests-sse.

@overcat overcat closed this as completed Dec 20, 2023
@xqt
Copy link
Contributor Author

xqt commented Jan 4, 2025

@overcat: Pywikibot has dropped Python 3.7 support recently. From our scope the minimal requirement can be increased to Python 3.8. See https://phabricator.wikimedia.org/T378893.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants