Skip to content
This repository was archived by the owner on May 4, 2019. It is now read-only.

Commit b4cf972

Browse files
authored
Merge pull request #249 from osu-cass/feat/namespace
Feat/namespace pass namespace of an item for accessibility api
2 parents 0228fae + 8b94d40 commit b4cf972

File tree

5 files changed

+8
-1
lines changed

5 files changed

+8
-1
lines changed

mocks/AboutItem/mocks.ts

+1
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,7 @@ export const rubricsEsn: RubricModel[] = [
160160
export const allRubrics: RubricModel[] = mockRubrics.concat(rubricsEsn);
161161

162162
export const aboutItemRevisionMockModel: AboutItemRevisionModel = {
163+
namespace: "Namespace",
163164
itemKey: "100",
164165
bankKey: "100",
165166
revision: "2",

src/AboutItem/AboutItemModels.ts

+1
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ export interface AboutItemRevision {
4646
}
4747

4848
export interface AboutItemRevisionModel {
49+
namespace: string;
4950
itemKey: string;
5051
bankKey: string;
5152
revision: string;

src/ItemBank/ItemBankContainer.tsx

+2-1
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,8 @@ export class ItemBankContainer extends React.Component<
116116
gradeLevel: item.AboutItemMetadata.intendedGrade,
117117
allowCalculator: this.makeBool(item),
118118
itemKey: item.AboutItemMetadata.identifier,
119-
bankKey: item.bankKey
119+
bankKey: item.bankKey,
120+
namespace: item.namespace
120121
};
121122
const prom = this.props.accessibilityClient(params);
122123
const promiseWrapper = this.subscription.add("accessibilityClient", prom);

src/ItemBank/ItemBankModels.ts

+1
Original file line numberDiff line numberDiff line change
@@ -201,6 +201,7 @@ export interface AccessibilityRevisionModel {
201201
interactionType: string;
202202
allowCalculator?: boolean;
203203
isPerformance?: boolean;
204+
namespace?: string;
204205
itemKey?: string;
205206
bankKey?: string;
206207
brailleType?: string;

src/ItemBank/__tests__/__snapshots__/ItemBankViewer.test.tsx.snap

+3
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,7 @@ exports[`ItemBankViewer with all props defined matches snapshot 1`] = `
162162
}
163163
bankKey="100"
164164
itemKey="100"
165+
namespace="Namespace"
165166
revision="2"
166167
sampleItemScoring={
167168
Object {
@@ -520,6 +521,7 @@ exports[`ItemBankViewer with revision model and accResourceGroup matches snapsho
520521
}
521522
bankKey="100"
522523
itemKey="100"
524+
namespace="Namespace"
523525
revision="2"
524526
sampleItemScoring={
525527
Object {
@@ -851,6 +853,7 @@ exports[`ItemBankViewer with revision model matches snapshot 1`] = `
851853
}
852854
bankKey="100"
853855
itemKey="100"
856+
namespace="Namespace"
854857
revision="2"
855858
sampleItemScoring={
856859
Object {

0 commit comments

Comments
 (0)