Skip to content
This repository was archived by the owner on May 4, 2019. It is now read-only.

Commit 4f13ed4

Browse files
committed
fix(item entry): adds logic to leave empty last row as valid
1 parent d7faf21 commit 4f13ed4

File tree

3 files changed

+11
-3
lines changed

3 files changed

+11
-3
lines changed

src/ItemBank/ItemBankModels.ts

+4
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,10 @@ export function validItemRevisionModel(itemRevisionModel?: ItemRevisionModel) {
143143
return value;
144144
}
145145

146+
export function isEmptyRevision(item: ItemRevisionModel): boolean {
147+
return !item.bankKey && !item.itemKey && !item.namespace;
148+
}
149+
146150
export function getItemBankIndex(
147151
currentItem: ItemRevisionModel,
148152
items: ItemRevisionModel[]

src/ItemEntryTable/ItemEntryTable.tsx

+5-2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ import {
88
SelectOption,
99
Select,
1010
validItemRevisionModel,
11-
ItemEntryRow
11+
ItemEntryRow,
12+
isEmptyRevision
1213
} from "@src/index";
1314

1415
export interface ItemEntryTableState {
@@ -55,8 +56,10 @@ export class ItemEntryTable extends React.Component<
5556
if (key === this.state.itemRows.length - 1) {
5657
itemRows.push({});
5758
}
58-
} else {
59+
} else if (!isEmptyRevision(row)) {
5960
row.valid = false;
61+
} else {
62+
row.valid = true;
6063
}
6164

6265
return { itemRows };

src/index.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,8 @@ export {
152152
concatNamespaceWith,
153153
getPreviousItemBank,
154154
getNextItemBank,
155-
getItemBankIndex
155+
getItemBankIndex,
156+
isEmptyRevision
156157
} from "./ItemBank/ItemBankModels";
157158
export { ItemBankViewer, ItemBankViewerProps } from "./ItemBank/ItemBankViewer";
158159

0 commit comments

Comments
 (0)