initial commit of postgresql "synchronous_commit on" during startup: not tested

Author: n-soda

lib/libgfarm/gfarm/config.c

@@ -978,9 +978,12 @@ int gfarm_write_verify_log_interval = GFARM_CONFIG_MISC_DEFAULT;
 
 /* GFM dependent */
 
+#define GFARM_METADB_BACKEND_SYNC_OFF_DURING_STARTUP_DEFAULT	1
+
 enum gfarm_backend_db_type gfarm_backend_db_type = GFARM_BACKEND_DB_TYPE_NONE;
 enum gfarm_db_access_type gfarm_db_access_type = GFARM_DB_ACCESS_TYPE_DBQ;
 int gfarm_metadb_server_listen_backlog = GFARM_CONFIG_MISC_DEFAULT;
+int gfarm_metadb_backend_sync_off_during_startup = GFARM_CONFIG_MISC_DEFAULT;
 
 static struct {
 	enum gfarm_atime_type type;
@@ -3470,6 +3473,10 @@ parse_one_line(const char *s, char *p,
 		    gfarm_auth_server_cred_name_set);
 	} else if (strcmp(s, o = "metadb_db_access_type") == 0) {
 		e = parse_db_access_type(p);
+	} else if (strcmp(s, o = "metadb_backend_sync_off_during_startup") == 0
+	    ) {
+		e = parse_set_misc_enabled(p,
+		    &gfarm_metadb_backend_sync_off_during_startup);
 
 	} else if (strcmp(s, o = "ldap_server_host") == 0) {
 		e = parse_set_var(p, &gfarm_ldap_server_name);
@@ -4030,6 +4037,9 @@ gfarm_config_set_default_misc(void)
 	if (gfarm_write_verify_log_interval == GFARM_CONFIG_MISC_DEFAULT)
 		gfarm_write_verify_log_interval =
 		    GFARM_WRITE_VERIFY_LOG_INTERVAL_DEFAULT;
+	if (metadb_backend_sync_off_during_startup == GFARM_CONFIG_MISC_DEFAULT)
+		gfarm_metadb_backend_sync_off_during_startup =
+			GFARM_METADB_BACKEND_SYNC_OFF_DURING_STARTUP_DEFAULT;
 
 	if (gfarm_spool_server_listen_backlog == GFARM_CONFIG_MISC_DEFAULT)
 		gfarm_spool_server_listen_backlog = LISTEN_BACKLOG_DEFAULT;

lib/libgfarm/gfarm/config.h

@@ -69,6 +69,8 @@ enum gfarm_db_access_type {
 };
 extern enum gfarm_db_access_type gfarm_db_access_type;
 
+extern int gfarm_metadb_backend_sync_off_during_startup;
+
 /* auth TLS dependent */
 #define GFARM_TLS_CERTIFICATE_PATH_DEFAULT		"/etc/pki/tls/certs"
 #define GFARM_TLS_KEY_PATH_DEFAULT			"/etc/pki/tls/private"

server/gfmd/db_access.c

@@ -433,6 +433,14 @@ db_terminate(void)
 	return (e);
 }
 
+gfarm_error_t
+db_sync_mode(int mode)
+{
+	gfarm_mutex_lock(&db_access_mutex, diag, DB_ACCESS_MUTEX_DIAG);
+	e = ops->set_mode(mode);
+	gfarm_mutex_unlock(&db_access_mutex, diag, DB_ACCESS_MUTEX_DIAG);
+}
+
 pthread_mutex_t *
 get_db_access_mutex(void)
 {

server/gfmd/db_access.h

@@ -6,6 +6,7 @@
 
 gfarm_error_t db_initialize(void);
 gfarm_error_t db_terminate(void);
+gfarm_error_t db_sync_mode(int);
 void *db_thread(void *);
 int db_getfreenum(void);
 

server/gfmd/db_journal.c

@@ -149,6 +149,12 @@ db_journal_noaction(void)
 	return (GFARM_ERR_NO_ERROR);
 }
 
+static gfarm_error_t
+db_journal_sync_mode_noaction(int)
+{
+	return (GFARM_ERR_NO_ERROR);
+}
+
 gfarm_error_t
 db_journal_init_status(void)
 {
@@ -4859,6 +4865,7 @@ db_journal_mdhost_load(void *closure,
 struct db_ops db_journal_ops = {
 	db_journal_noaction,
 	db_journal_terminate,
+	db_journal_sync_mode_noaction,
 
 	db_journal_write_begin,
 	db_journal_write_end,

server/gfmd/db_journal_apply.c

@@ -985,6 +985,7 @@ db_journal_apply_mdhost_remove(gfarm_uint64_t seqnum, char *name)
 const struct db_ops db_journal_apply_ops = {
 	NULL,
 	NULL,
+	NULL,
 
 	db_journal_apply_begin,
 	db_journal_apply_end,

server/gfmd/db_ldap.c

@@ -1168,6 +1168,12 @@ gfarm_ldap_generic_info_get_foreach(
 
 /**********************************************************************/
 
+static gfarm_error_t
+gfarm_ldap_sync_mode_nop(int mode)
+{
+	return (GFARM_ERR_NO_ERROR);
+}
+
 static gfarm_error_t
 gfarm_ldap_nop(gfarm_uint64_t seqnum, void *arg)
 {
@@ -3426,6 +3432,7 @@ gfarm_ldap_quota_dir_load(void *closure,
 const struct db_ops db_ldap_ops = {
 	gfarm_ldap_initialize,
 	gfarm_ldap_terminate,
+	gfarm_ldap_sync_mode_nop,
 
 	gfarm_ldap_nop,
 	gfarm_ldap_nop,

server/gfmd/db_none.c

@@ -83,6 +83,13 @@ gfarm_none_terminate(void)
 
 /**********************************************************************/
 
+static gfarm_error_t
+gfarm_none_sync_mode_nop(int mode)
+{
+	/* do not call modify_seqnum(), this is just startup operation */
+	return (GFARM_ERR_NO_ERROR);
+}
+
 static gfarm_error_t
 gfarm_none_nop(gfarm_uint64_t seqnum, void *arg)
 {
@@ -609,6 +616,7 @@ gfarm_none_mdhost_load(void *closure,
 const struct db_ops db_none_ops = {
 	gfarm_none_initialize,
 	gfarm_none_terminate,
+	gfarm_none_sync_mode_nop,
 
 	gfarm_none_nop,
 	gfarm_none_nop,

server/gfmd/db_ops.h

@@ -169,6 +169,7 @@ struct db_mdhost_modify_arg {
 struct db_ops {
 	gfarm_error_t (*initialize)(void);
 	gfarm_error_t (*terminate)(void);
+	gfarm_error_t (*sync_mode)(int);
 
 	gfarm_error_t (*begin)(gfarm_uint64_t, void *);
 	gfarm_error_t (*end)(gfarm_uint64_t, void *);

server/gfmd/db_pgsql.c

@@ -257,6 +257,32 @@ gfarm_pgsql_initialize(void)
 	return (GFARM_ERR_NO_ERROR);
 }
 
+gfarm_error_t
+gfarm_pgsql_sync_mode(int mode)
+{
+	gfarm_error_t e;
+	PGresult *res;
+	const char *cmd
+
+	if (mode) {
+		cmd = "synchronous_commit on";
+	} else {
+		cmd = "synchronous_commit off";
+	}
+	res = PQexec(conn, cmd);
+	if (PQresultStatus(res) == PGRES_COMMAND_OK) {
+		gflog_info(GFARM_MSG_UNFIXED, "postgresql backend: %s", cmd);
+		e = GFARM_ERR_NO_ERROR;
+	} else {
+		gflog_error(GFARM_MSG_UNFIXED, "%s: %s: %s",
+		    diag, cmd, PQresultErrorMessage(res));
+		e = GFARM_ERR_UNKNOWN;
+	}
+
+	PQclear(res);
+	return (e);
+}
+
 gfarm_error_t
 gfarm_pgsql_terminate(void)
 {
@@ -266,7 +292,6 @@ gfarm_pgsql_terminate(void)
 	return (GFARM_ERR_NO_ERROR);
 }
 
-
 /**********************************************************************/
 
 uint64_t

server/gfmd/gfmd.c

@@ -1200,13 +1200,17 @@ boot_apply_db_journal(void)
 	static int boot_apply = 1;
 
 	gflog_info(GFARM_MSG_1003273, "start applying db journal");
+	if (gfarm_metadb_backend_sync_off_during_startup)
+		db_sync_mode_(0);
 	if ((e = create_detached_thread(db_journal_store_thread,
 	    &boot_apply)) != GFARM_ERR_NO_ERROR)
 		gflog_fatal(GFARM_MSG_1003274,
 		    "create_detached_thread(db_journal_store_thread): %s",
 		    gfarm_error_string(e));
 
 	db_journal_wait_for_apply_thread();
+	if (gfarm_metadb_backend_sync_off_during_startup)
+		db_sync_mode_(1);
 	gflog_info(GFARM_MSG_1003275, "end applying db journal");
 
 	/*