Skip to content
This repository was archived by the owner on Feb 3, 2025. It is now read-only.

Write test for physics/Gripper.cc #314

Closed
osrf-migration opened this issue Dec 19, 2012 · 12 comments
Closed

Write test for physics/Gripper.cc #314

osrf-migration opened this issue Dec 19, 2012 · 12 comments
Labels

Comments

@osrf-migration
Copy link

Original report (archived issue) by Nate Koenig (Bitbucket: Nathan Koenig).


Gripper.cc depends on contact events in Collision.cc. This functionality is deprecated and needs to be removed.

@osrf-migration
Copy link
Author

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


  • changed title from "Remove deprecated function dependency in physics/Gripper.cc" to "Remove deprecated function dependency in physics/Gripper.cc"

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


It looks like this dependency was resolved by pull request #195. I think we can mark the Collision::ConnectContact and Collision::DisconnectContact functions as GAZEBO_DEPRECATED for 1.4.

@osrf-migration
Copy link
Author

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


I also need to test the gripper (and write test for it).

@osrf-migration
Copy link
Author

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


  • changed state from "new" to "on hold"

Until 2.0

@osrf-migration
Copy link
Author

Original comment by Ian Chen (Bitbucket: Ian Chen, GitHub: iche033).


  • changed state from "on hold" to "open"

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


  • changed kind from "bug" to "enhancement"
  • set component to "testing"
  • changed title from "Remove deprecated function dependency in physics/Gripper.cc" to "Write test for physics/Gripper.cc"

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


pull request #713

@osrf-migration
Copy link
Author

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


  • changed state from "open" to "resolved"

Resolved in pull request #713

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


Some of the deprecated behavior was removed but not included in the migration guide. I will update the migration guide to include a list of the removed functions as well as a recommendation for replacement functionality.

@wwoodall

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


I've updated the migration guide in ca30b24 (pull request #1077).

@osrf-migration
Copy link
Author

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


  • set version to "all"

@osrf-migration
Copy link
Author

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


  • changed state from "resolved" to "closed"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant