Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test-race (00) timing out in TestSnapshotWithPruning #159

Closed
p0mvn opened this issue Mar 27, 2022 · 0 comments · Fixed by #160
Closed

Fix test-race (00) timing out in TestSnapshotWithPruning #159

p0mvn opened this issue Mar 27, 2022 · 0 comments · Fixed by #160
Assignees
@p0mvn
Labels
frog

Comments

@p0mvn
Copy link
Member

p0mvn commented Mar 27, 2022

Context

I think this has to do with -race tests being slower than regular and, as a result, timing out. The test passes on my local machine without a timeout. So it might just mean that we need to find the right timeout value for the CI host machine.

We can tweak the timeout value here:

cosmos-sdk/baseapp/baseapp_test.go

Line 144 in d53f1dd

snapshotTimeout := 1 * time.Minute

Feel free to merge this PR, I can find the right value for the timeout in a separate PR

Originally posted by @p0mvn in #158 (comment)
@p0mvn p0mvn moved this to 🔍 Needs Review in Osmosis Chain Development Mar 27, 2022
@p0mvn p0mvn added the frog label Mar 27, 2022
@p0mvn p0mvn self-assigned this Mar 27, 2022
@p0mvn p0mvn linked a pull request Mar 27, 2022 that will close this issue
fix: test-race (00) #160
Merged
Repository owner moved this from 🔍 Needs Review to ✅ Done in Osmosis Chain Development Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p0mvn p0mvn

Labels
frog
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: test-race (00) osmosis-labs/cosmos-sdk
1 participant
@p0mvn