Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GitLab URLs in CLI #35

Closed
trivialkettle opened this issue Nov 6, 2023 · 6 comments
Closed

Support GitLab URLs in CLI #35

trivialkettle opened this issue Nov 6, 2023 · 6 comments

Comments

@trivialkettle
Copy link
Contributor

Hi,
if I use the CLI I cannot customize the compare links / tags links. Is is possible to add an CLI option to change to GitLab urls?

GitLab compare links: https://gitlab.com/gitlab-org/gitlab-runner/-/compare/0.4.0...0.4.1
GitLab tag link: https://gitlab.com/gitlab-org/gitlab-runner/-/tags/v16.0.0
Note the dash between repository URL and compare and tags.

AFAIK GitLab does not support HEAD to compare unreleased commits. We could use main as default.
Thanks.

@trivialkettle
Copy link
Contributor Author

#36 and #37 were some issues I noticed while testing a solution for this with a custom compareLinkBuilder in bin.ts.

In #37 you wrote, that you want to create an object for some well known services, would this be in the cli or library code?

@oscarotero
Copy link
Owner

@trivialkettle it would be only in the CLI (for now).

I just made these changes 5990d63
what do you think?

@trivialkettle
Copy link
Contributor Author

I am not an experienced JS/TS developer, but looks good so far.

Though since you can self host gitlab, we could need an way to detect self hosted gitlab instances like gitlab.exmaple.com.

@oscarotero
Copy link
Owner

Okay, I just updated the code and now can detects gitlab.com and gitlab.*

@oscarotero
Copy link
Owner

Okay, I just released 2.5.0. If you catch any bug, feel free to open more issues.
Thanks!

@trivialkettle
Copy link
Contributor Author

Works like a charm. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants