Follow Facebook login redirect #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Facebook redirects to login for all posts, but with a token the OEmbed info is still readable. This change gets the original url from the `next` query parameter of the redirected login and queries the relevant oembed endpoint. Fixes oscarotero#450
oscarotero
requested changes
Jun 19, 2021
Thanks for pointing out this function (I use a lot of php but usually a bit higher level, so didn't know it existed).
oscarotero
requested changes
Jun 21, 2021
Co-authored-by: Oscar Otero <[email protected]>
oscarotero
approved these changes
Jun 22, 2021
|
Thank you! 👍 |
|
My pleasure, it's a great library you built up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Facebook redirects to login for all posts, but with a token the OEmbed info is still readable. This change gets the original url from the
nextquery parameter of the redirected login and queries the relevant oembed endpoint.Fixes #450