Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook notification based system #776

Closed
merlindorin opened this issue Oct 19, 2020 · 6 comments
Closed

Webhook notification based system #776

merlindorin opened this issue Oct 19, 2020 · 6 comments
Labels
feat New feature or request. stale Feedback from one or more authors is required to proceed.
Milestone

Comments

@merlindorin
Copy link

Is your feature request related to a problem? Please describe.

Currently, smtp is implemented so we can send an email for an account registration... but how can I handle "sms" notification, "slack" notification or whatever?

Describe the solution you'd like

Have the opportunity to be ory implementation free through a webhook. e.g.

+-------------------+    +---------+    +--------------+    +-------------+
| user registration +--->| webhook +--->| email-sender +--->| smtp server |
+-------------------+    +---------+    +--------------+    +-------------+

Describe alternatives you've considered

SMTP custom implementation for sending sms? #kidding

Additional context

@merlindorin
Copy link
Author

After reading the source... lot of fun/works in this feature request xD.

@aeneasr Do we have a work in progress for sms? There is some opinionated works around this feature and, if I have time, I don't want to move in the bad direction (interface for courrier, separate models from smtp specific func like EmailRecipient, move templating in a SMTPCourier implementation, strategy->link->send update, etc.)

@aeneasr
Copy link
Member

aeneasr commented Oct 20, 2020

@aeneasr Do we have a work in progress for sms? There is some opinionated works around this feature and, if I have time, I don't want to move in the bad direction (interface for courrier, separate models from smtp specific func like EmailRecipient, move templating in a SMTPCourier implementation, strategy->link->send update, etc.)

We don't right now, unfortunately :)

@aeneasr aeneasr added the feat New feature or request. label Oct 20, 2020
@aeneasr aeneasr added this to the v0.7.0-alpha.1 milestone Oct 20, 2020
@eshepelyuk
Copy link

Isn't it related to #1030 ?

@aeneasr
Copy link
Member

aeneasr commented Feb 17, 2021

Yeah, I think they are about more or less the same thing.

@eshepelyuk
Copy link

Sorry for multipost,
I'm just trying to check a roadmap and some issues are in 0.7 and some are not.
So tryin ot figure out if those issues are really planned for 0.7

@github-actions
Copy link

Hello contributors!

I am marking this issue as stale as it has not received any engagement from the community or maintainers a year. That does not imply that the issue has no merit! If you feel strongly about this issue

  • open a PR referencing and resolving the issue;
  • leave a comment on it and discuss ideas how you could contribute towards resolving it;
  • leave a comment and describe in detail why this issue is critical for your use case;
  • open a new issue with updated details and a plan on resolving the issue.

Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic.

Unfortunately, burnout has become a topic of concern amongst open-source projects.

It can lead to severe personal and health issues as well as opening catastrophic attack vectors.

The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone.

If this issue was marked as stale erroneous you can exempt it by adding the backlog label, assigning someone, or setting a milestone for it.

Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you!

Thank you 🙏✌️

@github-actions github-actions bot added the stale Feedback from one or more authors is required to proceed. label Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request. stale Feedback from one or more authors is required to proceed.
Projects
None yet
Development

No branches or pull requests

3 participants