-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement crypt(3)
hashers
#3303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. This looks really good already, I just have two minor comments below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, LGTM! 🎉
Docs are already done :) |
Oh missed that, thanks! |
Implement
crypt(3)
based hashers.This PR implements
md5crypt
,sha256crypt
,sha512crypt
, which are considered legacy (likemd5
), but are used in legacy systems looking to convert to ory. They use the existing format ofcrypt(5)
(which is compliant to PHC).Related issue(s)
crypt(3)
hashes #3291Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments