Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add “provider id” parameter to kratos session #3283

Closed
wants to merge 1 commit into from

Conversation

splaunov
Copy link
Contributor

It is important to know which provider was used for authentication with OIDC. This information might be used for authorisation decisions where corporate customers are using OIDC-based SSO for access to Kratos-protected system.
This PR adds OIDC provider id into session structure.

Related issue(s)

Checklist

  • [ x] I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • [ x] I am following the
    contributing code guidelines.
  • [x ] I have read the security policy.
  • [ x] I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • [x ] I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@splaunov splaunov requested review from aeneasr and zepatrik as code owners May 15, 2023 13:37
@splaunov splaunov changed the title feat(oidc): add “provider id” parameter to kratos session (CORE-2073) feat(oidc): add “provider id” parameter to kratos session May 15, 2023
@splaunov splaunov changed the title feat(oidc): add “provider id” parameter to kratos session feat: add “provider id” parameter to kratos session May 15, 2023
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! 🎉 Your contribution makes Ory better :)

@aeneasr
Copy link
Member

aeneasr commented May 25, 2023

Fixed the merge conflicts and pushed to #3292 because I don't have write access to this fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants