-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update correct typo #3281
fix: update correct typo #3281
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3281 +/- ##
==========================================
+ Coverage 78.01% 78.02% +0.01%
==========================================
Files 327 327
Lines 21284 21296 +12
==========================================
+ Hits 16604 16616 +12
Misses 3447 3447
Partials 1233 1233
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, great change.
Hello @jonas-jonas, can we merge this soon? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, looking at this close, we also use this label for recovery, where "Verification code" would not be the right term. But we use one label for both. This would be a breaking change.
WDYT @aeneasr?
In that case we indeed need to split the text message and introduce a new message ID. I think that's fine in terms of backwards compatibility |
@jonas-jonas could you quickly do that? |
The text for verification code input should be `Verification code` not `Verify code`.
Signed-off-by: Giau. Tran Minh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you! 🎉 Your contribution makes Ory better :)
The text for verification code input should be
Verification code
notVerify code
.Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments