Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: run Playwright in CI #3259

Merged
merged 7 commits into from
May 2, 2023
Merged

test: run Playwright in CI #3259

merged 7 commits into from
May 2, 2023

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Apr 27, 2023

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl self-assigned this Apr 27, 2023
@hperl hperl changed the title tests: run Playwright in CI test: run Playwright in CI Apr 27, 2023
@hperl hperl force-pushed the hperl/app-oidc-e2e-tests branch from 0f061cc to 89d57fb Compare April 27, 2023 09:36
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #3259 (fa72f1a) into master (6db70a8) will decrease coverage by 0.03%.
The diff coverage is 72.50%.

❗ Current head fa72f1a differs from pull request most recent head a258713. Consider uploading reports for the commit a258713 to get more accurate results

@@            Coverage Diff             @@
##           master    #3259      +/-   ##
==========================================
- Coverage   78.14%   78.11%   -0.03%     
==========================================
  Files         324      324              
  Lines       20760    20754       -6     
==========================================
- Hits        16222    16213       -9     
  Misses       3333     3333              
- Partials     1205     1208       +3     
Impacted Files Coverage Δ
selfservice/flow/login/hook.go 84.67% <0.00%> (ø)
selfservice/flow/registration/error.go 68.11% <0.00%> (ø)
selfservice/flow/registration/hook.go 71.73% <0.00%> (ø)
selfservice/sessiontokenexchange/persistence.go 100.00% <ø> (ø)
session/manager.go 100.00% <ø> (ø)
selfservice/hook/session_issuer.go 80.00% <40.00%> (+0.58%) ⬆️
persistence/sql/persister.go 69.89% <50.00%> (-0.90%) ⬇️
selfservice/flow/login/error.go 70.31% <50.00%> (+0.47%) ⬆️
selfservice/flow/login/handler.go 78.82% <60.00%> (-1.49%) ⬇️
persistence/sql/persister_sessiontokenexchanger.go 97.33% <100.00%> (+0.55%) ⬆️
... and 2 more

... and 1 file with indirect coverage changes

@hperl hperl force-pushed the hperl/app-oidc-e2e-tests branch 2 times, most recently from 5ac34a0 to b5d2e58 Compare April 27, 2023 10:36
@hperl hperl force-pushed the hperl/app-oidc-e2e-tests branch from b5d2e58 to 6ca5730 Compare April 27, 2023 10:43
@hperl hperl force-pushed the hperl/app-oidc-e2e-tests branch from 8d1e463 to a612d65 Compare April 27, 2023 11:52
This improves the compatibility between OIDC+code and other
flows such as TOTP, settings, password auth.
@hperl hperl force-pushed the hperl/app-oidc-e2e-tests branch from 56b73c9 to 7efa9a4 Compare April 28, 2023 11:53
@hperl hperl requested a review from jonas-jonas April 28, 2023 11:54
@hperl hperl force-pushed the hperl/app-oidc-e2e-tests branch from b9d588d to 3662e7c Compare April 30, 2023 06:57
@hperl hperl marked this pull request as ready for review May 2, 2023 08:16
@hperl hperl requested review from aeneasr and zepatrik as code owners May 2, 2023 08:16
@hperl hperl requested a review from jonas-jonas May 2, 2023 10:20
@hperl hperl merged commit 342edec into master May 2, 2023
@hperl hperl deleted the hperl/app-oidc-e2e-tests branch May 2, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants