-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: emit events for login/logout and registration #3235
Conversation
d4e8033
to
f84929a
Compare
Codecov Report
@@ Coverage Diff @@
## master #3235 +/- ##
==========================================
- Coverage 77.92% 77.90% -0.02%
==========================================
Files 319 320 +1
Lines 20446 20474 +28
==========================================
+ Hits 15932 15950 +18
- Misses 3318 3325 +7
- Partials 1196 1199 +3
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ad12d60
to
0f20039
Compare
0f20039
to
99248f3
Compare
I want to especially get feedback concerning the placement of the event emitting code. |
8a037d4
to
084cfa6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
design-wise this LGTM
d099617
to
59d23dc
Compare
59d23dc
to
3dcd585
Compare
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments