You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I had discussed this in issue #949 and removed it from my PR #956 suggesting we add it to #948 instead. I see that NewHandler was exported but this doesn't boostrap the hydra features into the handler.
I think exporting registerRoutes is necessary to make this useful. I'd also suggest we consider exporting rejectInsecureRequests and possibly even enhanceRouter as they also perform helpful bootstrap options but are not necessary.
I can submit a PR to export these functions if you find it agreeable!
EDIT:
Exporting enhanceRouter would remove the need to export registerRoutes as it has access and uses it.
The text was updated successfully, but these errors were encountered:
I had discussed this in issue #949 and removed it from my PR #956 suggesting we add it to #948 instead. I see that
NewHandler
was exported but this doesn't boostrap the hydra features into the handler.I think exporting
registerRoutes
is necessary to make this useful. I'd also suggest we consider exportingrejectInsecureRequests
and possibly evenenhanceRouter
as they also perform helpful bootstrap options but are not necessary.I can submit a PR to export these functions if you find it agreeable!
EDIT:
Exporting
enhanceRouter
would remove the need to exportregisterRoutes
as it has access and uses it.The text was updated successfully, but these errors were encountered: