Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/server: Export useful bootstrap function #973

Closed
someone1 opened this issue Aug 7, 2018 · 5 comments
Closed

cmd/server: Export useful bootstrap function #973

someone1 opened this issue Aug 7, 2018 · 5 comments
Labels
feat New feature or request.
Milestone

Comments

@someone1
Copy link
Contributor

someone1 commented Aug 7, 2018

I had discussed this in issue #949 and removed it from my PR #956 suggesting we add it to #948 instead. I see that NewHandler was exported but this doesn't boostrap the hydra features into the handler.

I think exporting registerRoutes is necessary to make this useful. I'd also suggest we consider exporting rejectInsecureRequests and possibly even enhanceRouter as they also perform helpful bootstrap options but are not necessary.

I can submit a PR to export these functions if you find it agreeable!

EDIT:
Exporting enhanceRouter would remove the need to export registerRoutes as it has access and uses it.

@aeneasr
Copy link
Member

aeneasr commented Aug 7, 2018

Exporting them sounds OK to me!

@aeneasr
Copy link
Member

aeneasr commented Aug 7, 2018

Oh and could you, once those are all done, add an example to the advanced section in the docs?

@someone1
Copy link
Contributor Author

someone1 commented Aug 7, 2018

Sure I don't mind adding an example - do you just want a basic example of how to bootstrap hydra outside of hydra?

@aeneasr
Copy link
Member

aeneasr commented Aug 7, 2018

Yeah, basic example would be perfect!

@aeneasr aeneasr added the feat New feature or request. label Aug 10, 2018
@aeneasr aeneasr added this to the unplanned milestone Aug 10, 2018
@someone1
Copy link
Contributor Author

closed by #1023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request.
Projects
None yet
Development

No branches or pull requests

2 participants