Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus metrics #669

Closed
stijndehaes opened this issue Dec 4, 2017 · 6 comments
Closed

Prometheus metrics #669

stijndehaes opened this issue Dec 4, 2017 · 6 comments
Milestone

Comments

@stijndehaes
Copy link

Hi,

We are using hydra in our production environment on kubernetes. We have some small issues with hydra at the moment and want to investigate further. Our stack uses prometheus for monitoring.

For prometheus monitoring we would like and endpoint that exposes the current metrics in valid prometheus format. I would propose an another endpoint /health/prometheus.

Does that seem allright with you? Will you implement this or are you expecting a PR.

Kind Regards,
Stijn De Haes

@stijndehaes stijndehaes changed the title Prometheus metrics and json logging Prometheus metrics Dec 4, 2017
@aeneasr
Copy link
Member

aeneasr commented Dec 4, 2017

How stable is the Prometheus protocol/payload you would like to include?

@aeneasr
Copy link
Member

aeneasr commented Dec 4, 2017

Is it possible to pipe stdout/stderr to prometheus instead?

@elliots
Copy link

elliots commented Jan 9, 2018

Apologies for the +1 but metrics for prometheus would be great for us too.

@sboulkour
Copy link

sboulkour commented Jan 11, 2018

Hey @arekkas, regarding the stability of the Prometheus protocol, it is currently the de facto standard for kubernetes deployments monitoring. Prometheus and Kubernetes are part of the CNCF (https://www.cncf.io/) and are here to stay for some time from my point of view.

@aeneasr
Copy link
Member

aeneasr commented Jan 11, 2018

If anyone wants to tackle this, I'm open to discuss it and review PRs :)

@aeneasr
Copy link
Member

aeneasr commented May 24, 2018

Solved on master, see #827

@aeneasr aeneasr closed this as completed May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants