-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ES256 JWK Algo #627
Comments
closed in favor of #628 |
I think we should disable the P521 generator for now, as it's not safe to use them for repeated use in private keys. |
RFC7518 lists
I think that the stronger algorithm should continue to be supported. Also, the webcrypto spec has renamed
|
Ok, let's keep them then. As long as JWK/JWT spec talk of ES521 I think we should keep it that way. Definitely doesn't help though that there are naming inconsistencies now. |
Can you link to the spec which still references ES521? |
My bad, looks like I got mixed up, it's definitely ES512 |
I closed this because ES512 is now tracked in #651 |
It looks like support for ES256 is available (jwk/generator_ecdsa256.go), but that the JWK handler doesn't support it (https://github.com/ory/hydra/blob/master/jwk/handler.go#L27-L38).
Go's P-256 is implementation is constant-time (which prevents certain types of attacks) while its P-384 and P-521 are not (https://github.com/gtank/cryptopasta).
The text was updated successfully, but these errors were encountered: