Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headers should be case-insensitive #496

Closed
meyerzinn opened this issue Jun 6, 2017 · 4 comments
Closed

Headers should be case-insensitive #496

meyerzinn opened this issue Jun 6, 2017 · 4 comments

Comments

@meyerzinn
Copy link

I'm trying to run Hydra on Kubernetes behind a Google Cloud Engine load balancer with SSL termination, but the load balancer converts headers to lowercase. The RFC (RFC 7230) for HTTP/1.1 Message Syntax and Routing says that header fields have a case-insensitive field name.

return errors.New("X-Forwarded-Proto header is missing")

@aeneasr
Copy link
Member

aeneasr commented Jun 6, 2017

I am confident that r.Header.Get() follows RFC 7230, otherwise most Go applications would not properly work with http. What issue are you observing exactly?

@meyerzinn
Copy link
Author

Hydra fails requests through the load balancer because it's seemingly missing X-Forwarded-Proto. However, the docs say that that header is added.

@aeneasr
Copy link
Member

aeneasr commented Jun 7, 2017

I can't reproduce this:

image

image

@aeneasr aeneasr closed this as completed Jun 7, 2017
@toddams
Copy link

toddams commented Feb 14, 2020

@20zinnm How did you resolve your issue? I'm having exactly the same situation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants