Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hydra configuration editor crashes #722

Closed
5 of 6 tasks
tomekpapiernik opened this issue Mar 29, 2022 · 3 comments
Closed
5 of 6 tasks

Hydra configuration editor crashes #722

tomekpapiernik opened this issue Mar 29, 2022 · 3 comments
Assignees
Labels
area/docs This issue affects Ory's documentation. bug Something is not working.

Comments

@tomekpapiernik
Copy link
Contributor

Preflight checklist

Describe the bug

Trying to access the Hydra config editor the page crashes.

https://www.ory.sh/docs/hydra/reference/configuration-editor

Originally reported by a community member:
https://ory-community.slack.com/archives/C012RBW0F18/p1648498590345789

Reproducing the bug

  1. go to https://www.ory.sh/docs/hydra/reference/configuration-editor
  2. enjoy the show

Relevant log output

No response

Relevant configuration

No response

Version

current

On which operating system are you observing this issue?

No response

In which environment are you deploying?

No response

Additional Context

No response

@tomekpapiernik tomekpapiernik added bug Something is not working. area/docs This issue affects Ory's documentation. labels Mar 29, 2022
@gen1us2k
Copy link
Contributor

I found the issue that causes a webpage crash. The reason lies in spec/config.json. I fixed this with this patch

diff --git a/spec/config.json b/spec/config.json
index 0e8b7baa..c5ea89c6 100644
--- a/spec/config.json
+++ b/spec/config.json
@@ -1214,11 +1214,9 @@
     },
     "dangerous-allow-insecure-redirect-urls": {
       "type": "array",
-      "items": [
-        {
+      "items": {
           "type": "string"
-        }
-      ],
+      },
       "title": "Disable HTTPS enforcement for the provided redirect URLs.",
       "description": "DO NOT USE THIS IN PRODUCTION - Disable HTTPS enforcement for the provided redirect URLs. This is only available as CLI flag `--dangerous-allow-insecure-redirect-urls`."
     }

Also, I found that we use the master branch for config editors. I see two possible solutions:

  1. use tags instead of master branch for configuration references
  2. Fix config.json generators

@tomekpapiernik
Copy link
Contributor Author

@gen1us2k
I see that the page still fails whenever you try to access it. Could you please make sure that this behavior is fixed? Any other improvements or updates can be added in subsequent PRs. Thanks!

@gen1us2k
Copy link
Contributor

gen1us2k commented May 5, 2022

@tomekpapiernik PR is opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs This issue affects Ory's documentation. bug Something is not working.
Projects
None yet
Development

No branches or pull requests

2 participants