Refactor deployers #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 5, 2017 08:13
The existing "check" approach called loadComponents(file), which loaded all components from "file" into the next group, and then called configureComponents(), which configured *all* groups. This results in configuring components in some layers multiple times, if multiple files are loaded. e.g. - kickStart(file1); - kickStart(file2); results in - load components from file 1 - configure components from file 1 - load components from file 2 - configure components from file 1 // BAD! - configure components from file 2 The fix is to use the internal load/configure/start functions that know about groups, and which only load/configure/start the components of the current group. This effectively needs a kickStart() that knows whether the user wants to start components or not (which is the only net difference between a deployment run with and without checking.
Avoid configuring components multiple times by using the new kick start capability, which correctly works per group (ie file).
Avoid duplicated code. Fix the logged output to account for the TLSF overhead.
|
I had to disable the TLSF dump in a145784 because RTT is built without TLSF debugging by default ( |
|
On Apr 28, 2017, at 17:31, Johannes Meyer ***@***.***> wrote:
I had to disable the TLSF dump in a145784 <a145784> because RTT is built without TLSF debugging by default (OS_RT_MALLOC_DEBUG=OFF). Ideally we add the flag to the generated target config header so that OCL and other packages can check whether TLSF debugging was enabled or not in RTT.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#57 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJuI_Cs78DVKKMSemDKCUysZVbNNiH_ks5r0hR-gaJpZM4Mh1xO>.
Ok, thanks. Sorry about that - that shouldn’t have slipped in.
S
|
meyerj
added a commit
that referenced
this pull request
Apr 17, 2019
This is a regression from #74, which removed the `using namespace std` directive, but was picked from a branch were #57 was already applied. The latter moved the tlsf log output from the individual deployers to a centralized class in `deployer-funcs.cpp` and therefore did not require the using namespace directive anymore. Signed-off-by: Johannes Meyer <[email protected]>
meyerj
added a commit
that referenced
this pull request
Apr 17, 2019
This is a regression from #74, which removed the `using namespace std` directive, but was picked from a branch were #57 was already applied. The latter moved the tlsf log output from the individual deployers to a centralized class in `deployer-funcs.cpp` and therefore did not require the using namespace directive anymore. Signed-off-by: Johannes Meyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the TLSF code in the three (3) deployers.
Add code to dump TLSF statistics