-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup code block tags #131
Comments
It already does that. It strips tags that only have meaning for //! ```should_panic
//! fail!("foo");
//! ```
cargo-rdme generates this README: ```rust
fail!("foo");
``` This stuff is tested here: cargo-rdme/src/transform/rust_markdown_tag.rs Line 321 in 4191ebb
If this is not what you mean, please give a concrete example. |
Yes it does. I'm very sorry. For whatever reason I used "rust,no_compile" (and not ignore, I have no idea where I picked that up). Interestingly enough the rust doc does what I want: do rust syntax highlight and not show a "untested" badge next to it (as ignore does). |
It seems When it does I'll update cargo-rdme to support that. |
Since the code blocks in the readme often do not compile anyway due to removing the comments, the extra tags are probably not helpful and can be removed/replaced.
Suggestion: when a code block is identified as rust (is_rust_code_block) then remove all tags and replace it with "rust".
Should probably optional or possible to switch off. Also someone may want to have another tag (including the empty string).
The text was updated successfully, but these errors were encountered: