-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable configuring a certificate authority file for registry client. #217
Comments
Hi, I would like to work on this issue if possible. Regards, |
Should we target using oras-go v2? |
@sajayantony I would recommend it be part of |
👍 should be fixed in v2 first, then would need a backport to v1 for Helm users to take advantage. PS, when there is a plan for the |
Update to this note. I was not aware that v2 has removed docker auth and implemented their own auth. Because of this v2 would have to implement things from scratch that v1 could do more easily using Docker client auth. So we may need to propose a working change for v1 to start which would then need to be ported to v2 (not backported from v2 to v1). V1 is needed for Helm at this point. However, to keep with our agreement to ensure v1 and v2 have the opportunity to stay in sync in terms of features, we should in that same proposal give a recommendation on how the new v2 auth would want to implement the same thing. This way, we can get signoff from the v2 maintainers before approving/merging into v1. So we at least stay on the same page with features even if the code is completely different. @sajayantony does this make sense to you? |
Just as Helm allows as
--kube-ca-file
option to use a specific certificate authority file for the Kubernetes API Server connection, it would be great if ORAS enabled requests to the registry to be made with a specific certificate authority, so that connections to internal private registries are not susceptible to machine-in-the-middle.Currently it appears the only option is to use the
--insecure
flag which I assume results in a TLS connection configured withInsecureSkipVerify
. As per the docs there "This should be used only for testing or in combination with VerifyConnection or VerifyPeerCertificate".The text was updated successfully, but these errors were encountered: